Grey bar is not visible in GeoPoint widget when user opens widget again with saved location

[mmarciniak90]

Software and hardware versions

Collect v1.17, older versions were not be verified
Google Maps

Problem description

Grey bar is not visible in GeoPoint widget when user opens widget again with saved location

Steps to reproduce the problem

1. User opens GeoPoint widget with Google map
2. User adds location and clicks on save icon
3. User opens GeoPoint widget again
4. User sees that grey bar is not available
5. User clicks on remove icon
6. Grey bar appears

Google Maps
OSM

Expected behavior

• This behavior is visible only for Geopoint widget with Google maps
• Grey bar is always available

Other information

Discovered while testing #2806

[huangyz0918]

@opendatakit-bot claim

[zestyping]

@mmarciniak90 As I understand it, the disappearance of the grey bar is intentional and by design. The bar says "Long press to place mark...". When there exists a saved location, the user cannot long-press to place a mark, so the instruction is not shown. After the user deletes the saved location, it is then possible again to long-press to place a mark, so the instruction is shown. Can you help me understand why you consider this to be a bug?

[huangyz0918]

The behavior of OSM and the Google Map are inconsistent, the OSM has the bar but the Google Map has not. So I guess this is the reason why @mmarciniak90 consider it as a bug. @zestyping

[zestyping]

@huangyz0918 Thank you for explaining, I understand.

This issue is obsolete now because the Google Maps activity and the OSM activity have been merged into a single activity after 1.17, so they now have the same behaviour. The change in the user-visible behaviour of this grey bar is noted in the description of #2776, the PR that merges the two activities into one activity, where it says:

• When the activity is launched with a previously saved point, marker dragging and long-press are initially disabled; the user must click the "trash" button to discard the point before adding/long-pressing/dragging a new marker. Previously, the instructions "Long press to place mark to tap add marker button" would be displayed even though the user cannot do these things; now the instructions are not displayed.

[huangyz0918]

@zestyping Thanks for explaining! So this issue is obsolete and should be closed. @mmarciniak90 , and I shall close #2859 too.