Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove custom handling for file types #3173

Closed
yanokwa opened this issue Jun 19, 2019 · 8 comments · Fixed by #3557
Closed

Remove custom handling for file types #3173

yanokwa opened this issue Jun 19, 2019 · 8 comments · Fixed by #3557
Assignees
Labels
good first issue Good for newcomers! Experienced ODK devs, only take these if they need to be fixed quickly. =) in progress

Comments

@yanokwa
Copy link
Member

yanokwa commented Jun 19, 2019

From #3163

"For a rainy day / good first issue, some of the types that Collect matches against are handled by the Android type mapper. It would be great for someone to go through and remove custom handling for those, I think."

@yanokwa yanokwa added good first issue Good for newcomers! Experienced ODK devs, only take these if they need to be fixed quickly. =) needs discussion labels Jun 19, 2019
@seadowg
Copy link
Member

seadowg commented Jun 19, 2019

This is in reference to CollectThenSystemContentTypeMapper which has quite a lot of hardcoded extension to content type mappings that it could probably be deferring to Android.

@lognaturel
Copy link
Member

Specifically, https://github.com/opendatakit/collect/blob/master/collect_app/src/main/java/org/odk/collect/android/http/CollectThenSystemContentTypeMapper.java#L34 has the custom map. The source for Android's MimeTypeMap is here. All of the mappings that match can be removed from the custom map.

@seadowg
Copy link
Member

seadowg commented Jun 20, 2019

I was worried that Android's version might not be the same for all the versions we support but it looks like from the log (https://android.googlesource.com/platform/frameworks/base/+log/61ae88e/core/java/android/webkit/MimeTypeMap.java) that it hasn't been touched for about 9 years.

It's probably worth checking once we've done this that "video/3gpp" still works on an API 16 device to make sure that the last changes made it in to Jelly Bean.

@chidauri
Copy link
Contributor

Hi, i want to work on this issue(it really is rainy day here :P)

@seadowg
Copy link
Member

seadowg commented Dec 26, 2019

@chidauri go for it! If you want to claim an issue have a look at this guide

@chidauri
Copy link
Contributor

@opendatakit-bot claim

@getodk-bot
Copy link
Member

Welcome to Open Data Kit, @chidauri! We just sent you an invite to collaborate on this repository at https://github.com/opendatakit/collect/invitations. Please accept this invite in order to claim this issue and begin a fun and rewarding experience contributing to Open Data Kit!

Here are some tips to get you off to a good start:

  • Please read the README.md and CONTRIBUTING.md in this repo. Those two documents have much of what you need to get started.
  • Join the ODK developer Slack to get help, chat about this issue, and meet the other developers.
  • Sign up and introduce yourself on the ODK community forum to meet the broader ODK community.

See you on the other side (that is, the pull request side)!

@getodk-bot
Copy link
Member

Hello @chidauri, you claimed this issue to work on it, but this issue and any referenced pull requests haven't been updated for 10 days. Are you still working on this issue?

If so, please update this issue by leaving a comment on this issue to let me know that you're still working on it. Otherwise, I'll automatically remove you from this issue in 5 days.

If you've decided to work on something else, simply comment @opendatakit-bot unclaim so that someone else can claim it and continue from where you left off.

Thank you for your valuable contributions to Open Data Kit!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers! Experienced ODK devs, only take these if they need to be fixed quickly. =) in progress
Projects
None yet
5 participants