-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove custom handling for file types #3173
Comments
This is in reference to |
Specifically, https://github.com/opendatakit/collect/blob/master/collect_app/src/main/java/org/odk/collect/android/http/CollectThenSystemContentTypeMapper.java#L34 has the custom map. The source for Android's |
I was worried that Android's version might not be the same for all the versions we support but it looks like from the log (https://android.googlesource.com/platform/frameworks/base/+log/61ae88e/core/java/android/webkit/MimeTypeMap.java) that it hasn't been touched for about 9 years. It's probably worth checking once we've done this that "video/3gpp" still works on an API 16 device to make sure that the last changes made it in to Jelly Bean. |
Hi, i want to work on this issue(it really is rainy day here :P) |
@chidauri go for it! If you want to claim an issue have a look at this guide |
@opendatakit-bot claim |
Welcome to Open Data Kit, @chidauri! We just sent you an invite to collaborate on this repository at https://github.com/opendatakit/collect/invitations. Please accept this invite in order to claim this issue and begin a fun and rewarding experience contributing to Open Data Kit! Here are some tips to get you off to a good start:
See you on the other side (that is, the pull request side)! |
Hello @chidauri, you claimed this issue to work on it, but this issue and any referenced pull requests haven't been updated for 10 days. Are you still working on this issue? If so, please update this issue by leaving a comment on this issue to let me know that you're still working on it. Otherwise, I'll automatically remove you from this issue in 5 days. If you've decided to work on something else, simply comment Thank you for your valuable contributions to Open Data Kit! |
From #3163
"For a rainy day / good first issue, some of the types that Collect matches against are handled by the Android type mapper. It would be great for someone to go through and remove custom handling for those, I think."
The text was updated successfully, but these errors were encountered: