Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PNGs are uploaded with jpg extension to Google Drive #742

Closed
lognaturel opened this issue Mar 22, 2017 · 1 comment
Closed

PNGs are uploaded with jpg extension to Google Drive #742

lognaturel opened this issue Mar 22, 2017 · 1 comment

Comments

@lognaturel
Copy link
Member

Software and hardware versions

Collect v1.4.16-127-g4673b97e

Problem description

PNG images are uploaded as JPGs to Google Drive. They get a .jpg extension but still appear to have transparency and the same size as the original PNG. When downloading the file, the extension can be changed to png.

Steps to reproduce the problem

  1. Set the protocol to "Google Drive, Google Sheets"
  2. Download a form that requires an image such as the demo form posted here
  3. Fill the form, pick a PNG for the image
  4. Upload the form
  5. Look at the image on Google Drive

Expected behavior

PNG images should be uploaded with .png extension.

@shobhitagarwal1612
Copy link
Contributor

shobhitagarwal1612 commented Mar 22, 2017

I was thinking, we can now finally allow uploading of all kind of media files. Currently, we are filtering out only the images using the attribute value. By removing this check and checking the file content before uploading, we can add support for all kinds of files. That will fix this issue as well.
@lognaturel Any thoughts?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants