address comments

Signed-off-by: Yingrong Zhao <[email protected]>
getporter · Jan 9, 2023 · 92d7d98 · 92d7d98
1 parent 8c1ac4f
commit 92d7d98
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 4 deletions.
diff --git a/controllers/agentaction_controller.go b/controllers/agentaction_controller.go
@@ -165,17 +165,14 @@ func (r *AgentActionReconciler) applyJobToStatus(log logr.Logger, action *porter
 		setCondition(log, action, porterv1.ConditionStarted, "JobStarted")
 	}
 
-conditions:
 	for _, condition := range job.Status.Conditions {
 		switch condition.Type {
 		case batchv1.JobComplete:
 			action.Status.Phase = porterv1.PhaseSucceeded
 			setCondition(log, action, porterv1.ConditionComplete, "JobCompleted")
-			break conditions
 		case batchv1.JobFailed:
 			action.Status.Phase = porterv1.PhaseFailed
 			setCondition(log, action, porterv1.ConditionFailed, "JobFailed")
-			break conditions
 		}
 	}
 }

diff --git a/magefiles/magefile.go b/magefiles/magefile.go
@@ -93,7 +93,7 @@ func Vet() {
 }
 
 func Lint() {
-	tools.EnsureStaticCheck()
+	mg.Deps(tools.EnsureStaticCheck)
 	must.RunV("staticcheck", "./...")
 }