Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Debug mode is not being picked up by the bundle runtime #2358

Closed
3 tasks
carolynvs opened this issue Sep 14, 2022 · 1 comment · Fixed by #2360
Closed
3 tasks

Debug mode is not being picked up by the bundle runtime #2358

carolynvs opened this issue Sep 14, 2022 · 1 comment · Fixed by #2360
Assignees
Labels
0 - 🚨🍩 Emergency donuts come first bug Oops, sorry!
Milestone

Comments

@carolynvs
Copy link
Member

When I run a bundle and specify --debug, that should cause the bundle to print out additional information, such as the commands being run.

mkdir mybuns && cd mybuns
porter create
porter install test --debug
# bundle output

The bundle output should include a line like /cnab/app ./helpers.sh install but it doesn't.

There seem to be a couple interrelated problems:

  • The RuntimeConfig.DebugMode value should be initialized to PORTER_DEBUG which is set in the bundle when run with --debug.
  • The verbosity configuration value isn't being overridden when set via --verbosity. Porter is only respecting the config file value and environment variable. This affects what porter prints out when running a bundle.
  • Some runtime structs and their functions have been updated to use telemetry, e.g. span.Info, but I suspect that when the TraceLogger is initialized inside a bundle, it isn't picking up the environment variables we are sending to set verbosity, otel, etc.
@carolynvs carolynvs added bug Oops, sorry! 0 - 🚨🍩 Emergency donuts come first labels Sep 14, 2022
@carolynvs carolynvs added this to the 1.0 milestone Sep 14, 2022
@carolynvs carolynvs self-assigned this Sep 14, 2022
@carolynvs carolynvs moved this to Done in Upcoming Releases Sep 15, 2022
@github-actions
Copy link

Closed by #2360.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0 - 🚨🍩 Emergency donuts come first bug Oops, sorry!
Projects
No open projects
Status: Done
Development

Successfully merging a pull request may close this issue.

1 participant