Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

porter create command should create directory with bundle files included #2772

Closed
2 tasks
phillipgibson opened this issue Jun 6, 2023 · 2 comments · Fixed by #2892
Closed
2 tasks

porter create command should create directory with bundle files included #2772

phillipgibson opened this issue Jun 6, 2023 · 2 comments · Fixed by #2892
Labels
good first issue Good for new contributors help wanted Good for someone who has contributed before

Comments

@phillipgibson
Copy link
Member

phillipgibson commented Jun 6, 2023

What design is being proposed?
When using porter create , the command will create all the files associated with the bundle in the current directory where ran. For a cleaner file system organization, a directory of the bundle name should be made with the files for the bundle created in that directory.

Additional Context
This functionality saves a step for the user. An example of this is how Rust uses the cargo new command.

Risks/Concerns
None that I'm aware of.

What other approaches were considered?
None

Implementation details
portal create mybundle
cd mybundle
ls - porter.yaml, README.md template.Dockerfile, etc.

Checklist

  • An announcement of this proposal has been sent to the Porter mailing list: https://getporter.org/mailing-list
  • This proposal has remained open for at least one week, to allow time for community feedback.
@schristoff
Copy link
Member

This functionality is also how helm create works, for anyone taking a peek at this issue it may be good to pull inspiration from their implementation here

@schristoff schristoff added help wanted Good for someone who has contributed before good first issue Good for new contributors labels Jun 8, 2023
@sbdtu5498
Copy link
Contributor

/assign

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for new contributors help wanted Good for someone who has contributed before
Projects
None yet
3 participants