Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bundles without "v"-tagged prefix cannot be pulled #2886

Closed
synicalsyntax opened this issue Aug 25, 2023 · 0 comments · Fixed by #2890
Closed

Bundles without "v"-tagged prefix cannot be pulled #2886

synicalsyntax opened this issue Aug 25, 2023 · 0 comments · Fixed by #2890
Assignees
Labels
1 - 🍫 Eat chocolate _after_ emergency donuts bug Oops, sorry! gap We missed a spot

Comments

@synicalsyntax
Copy link

synicalsyntax commented Aug 25, 2023

Describe the bug

Porter prepends "v" to the manifest-specified bundle version even though its registry tag might not have the v prefix (e.g. in format X.Y.Z), causing it to look for a vX.Y.Z tag that doesn't exist. See Slack for further discussion here.

To Reproduce

Reproduced by @bdegeeter

  1. Make an installation resource:
apiVersion: getporter.org/v1
kind: Installation
metadata:
  name: hello-llama
  namespace: demo
spec:
  schemaVersion: 1.0.2
  name: mellama
  namespace: demo
  bundle:
    repository: getporter/hello-llama
    version: 0.1.1
  parameters:
    name: quickstart
  1. Running porter explain -r getporter/hello-llama:0.1.1 matching the spec fails.

Expected behavior

porter explain -r getporter/hello-llama:0.1.1 should work regardless if there's a v in the version, such as the output resulting when v0.1.1 is specified in the manifest:

porter explain -r getporter/hello-llama:v0.1.1
Name: hello-llama
Description: An example Porter bundle with parameters
Version: 0.1.1
Porter Version: v0.38.1-32-gb76f5c1c

Parameters:
--------------------------------------------------------------------------------
  Name  Description                     Type    Default  Required  Applies To   
--------------------------------------------------------------------------------
  name  Name of to whom we should say   string  llama    false     All Actions  
        hello                                                                   

This bundle uses the following tools: exec.

To install this bundle run the following command, passing --param KEY=VALUE for any parameters you want to customize:
porter install --reference getporter/hello-llama:v0.1.1

Porter Command and Output

$ porter explain -r getporter/hello-llama:0.1.1
unable to pull bundle: docker.io/getporter/hello-llama:0.1.1: not found
unable to pull bundle: docker.io/getporter/hello-llama:0.1.1: not found

Version

porter v1.0.14 (0e739d8)

@synicalsyntax synicalsyntax added the bug Oops, sorry! label Aug 25, 2023
@troy0820 troy0820 added gap We missed a spot 1 - 🍫 Eat chocolate _after_ emergency donuts labels Aug 29, 2023
@schristoff schristoff moved this to 📋 Backlog in Porter Aug 29, 2023
@ludfjig ludfjig mentioned this issue Aug 29, 2023
4 tasks
@github-project-automation github-project-automation bot moved this from 📋 Backlog to ✅ Done in Porter Aug 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1 - 🍫 Eat chocolate _after_ emergency donuts bug Oops, sorry! gap We missed a spot
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants