Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default parameter and output types #1692

Merged
merged 1 commit into from
Jul 28, 2021

Conversation

carolynvs
Copy link
Member

What does this change

When the type is omitted on a parameter or output declaration in porter.yaml, default the type. If a path is specified, default to file, otherwise default to string.

What issue does it fix

Closes #1691

Notes for the reviewer

N/A

Checklist

  • Unit Tests
  • Documentation
  • Schema (porter.yaml)

When the type is omitted on a parameter or output declaration in
porter.yaml, default the type. If a path is specified, default to file,
otherwise default to string.

Signed-off-by: Carolyn Van Slyck <[email protected]>
@carolynvs carolynvs marked this pull request as ready for review July 28, 2021 14:49
Copy link
Member

@vdice vdice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@carolynvs carolynvs merged commit 007c52c into getporter:main Jul 28, 2021
@carolynvs carolynvs deleted the default-type-to-string branch July 28, 2021 21:11
@carolynvs carolynvs mentioned this pull request Aug 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Parameters and Outputs do not have a default type
2 participants