Fix check for if a bundle was provided #1706
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Install requires a bundle definition from either --reference, --file, --cnab-file or from the bundle in the current directory. The other commands can either use those or use the installation name to look up the bundle definition. I found a way to get install to execute without specifying a bundle definition and it blew up later in code that execpted that this had already been validated. The command was porter install --creds aks I didn't specify a --reference or anything and wasn't in a bundle directory. Hopefully this plugs the gaps in wher we check for this condition. Signed-off-by: Carolyn Van Slyck <[email protected]>
carolynvs
force-pushed
the
fix-bundle-check
branch
from
2952157 to
40332d8
Compare
vdice
approved these changes
Aug 10, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change
Install requires a bundle definition from either --reference, --file,
--cnab-file or from the bundle in the current directory. The other
commands can either use those or use the installation name to look up
the bundle definition.
I found a way to get install to execute without specifying a bundle
definition and it blew up later in code that execpted that this had
already been validated. The command was
porter install --creds aks
I didn't specify a --reference or anything and wasn't in a bundle
directory.
Hopefully this plugs the gaps in wher we check for this condition.
What issue does it fix
NA
Notes for the reviewer
I will merge this into v1 after it's merged into main.
Checklist