Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

On MAUI sentry-cli seems to only run before AOT, missing the AOT'd symbols #2137

Closed
kanadaj opened this issue Jan 30, 2023 · 0 comments · Fixed by #2145
Closed

On MAUI sentry-cli seems to only run before AOT, missing the AOT'd symbols #2137

kanadaj opened this issue Jan 30, 2023 · 0 comments · Fixed by #2145
Assignees
Labels
Bug Something isn't working

Comments

@kanadaj
Copy link
Contributor

kanadaj commented Jan 30, 2023

Package

Sentry.Maui

.NET Flavor

.NET

.NET Version

7.0.2

OS

Android

SDK Version

3.26.2

Self-Hosted Sentry Version

22.9.0

Steps to Reproduce

I'm uncertain of how to exactly reproduce it, will see about making a repro project.

Running dotnet publish for Android seems to run Sentry CLI before the AOT steps. This means that the AOT'd .so files don't get uploaded to Sentry, just the framework's and Sentry's .so files.

Expected Result

The Sentry-CLI step should run after AOT

Actual Result

dotnet publish --framework net7.0-android -c:Release /p:AndroidSigningKeyPass=$KEY_PASS /p:AndroidSigningStorePass=$KEY_PASS /p:AndroidSdkDirectory=/usr/lib/android-sdk
MSBuild version 17.4.1+9a89d02ff for .NET
  Determining projects to restore...
  Restored /builds/royal-road/royalroad.mobile/RoyalRoad.Mobile.Client/RoyalRoad.Mobile.Client.csproj (in 4.54 sec).
  Restored /builds/royal-road/royalroad.mobile/RoyalRoad.Mobile/RoyalRoad.Mobile.csproj (in 4.6 sec).
  RoyalRoad.Mobile.Client -> /builds/royal-road/royalroad.mobile/RoyalRoad.Mobile.Client/bin/Release/net7.0-android/RoyalRoad.Mobile.Client.dll
  Preparing to upload debug symbols to Sentry for RoyalRoad.Mobile.Client (Release/net7.0-android)
  > Found 12 debug information files
  > Prepared debug information files for upload
  > Nothing to upload, all files are on the server
  RoyalRoad.Mobile -> /builds/royal-road/royalroad.mobile/RoyalRoad.Mobile/bin/Release/net7.0-android/RoyalRoad.Mobile.dll
  RoyalRoad.Mobile.Client -> /builds/royal-road/royalroad.mobile/RoyalRoad.Mobile.Client/bin/Release/net7.0-android/RoyalRoad.Mobile.Client.dll
  Preparing to upload debug symbols to Sentry for RoyalRoad.Mobile.Client (Release/net7.0-android)
  > Found 12 debug information files
  > Prepared debug information files for upload
  > Nothing to upload, all files are on the server
  Optimizing assemblies for size may change the behavior of the app. Be sure to test after publishing. See: https://aka.ms/dotnet-illink
  Optimizing assemblies for size. This process might take a while.
  Optimizing assemblies for size may change the behavior of the app. Be sure to test after publishing. See: https://aka.ms/dotnet-illink
  Optimizing assemblies for size. This process might take a while.
  Optimizing assemblies for size may change the behavior of the app. Be sure to test after publishing. See: https://aka.ms/dotnet-illink
  Optimizing assemblies for size. This process might take a while.
  Optimizing assemblies for size may change the behavior of the app. Be sure to test after publishing. See: https://aka.ms/dotnet-illink
  Optimizing assemblies for size. This process might take a while.
  [1/169] Microsoft.AspNetCore.Components.Authorization.dll -> Microsoft.AspNetCore.Components.Authorization.dll.so
  [3/169] Blazorise.Bootstrap5.dll -> Blazorise.Bootstrap5.dll.so
  [2/169] Microsoft.AspNetCore.Metadata.dll -> Microsoft.AspNetCore.Metadata.dll.so
  [4/169] IdentityModel.dll -> IdentityModel.dll.so
  [5/169] Microsoft.AspNetCore.Components.WebView.Maui.dll -> Microsoft.AspNetCore.Components.WebView.Maui.dll.so
  [6/169] HtmlSanitizer.dll -> HtmlSanitizer.dll.so
  [7/169] Microsoft.AspNetCore.Components.Forms.dll -> Microsoft.AspNetCore.Components.Forms.dll.so
  [8/169] Microsoft.AspNetCore.Components.WebView.dll -> Microsoft.AspNetCore.Components.WebView.dll.so
  [9/169] AngleSharp.Css.dll -> AngleSharp.Css.dll.so
...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants