Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

stacktrace: deconstructFunctionName returns bad output for methods #126

Closed
rhcarvalho opened this issue Dec 18, 2019 · 0 comments · Fixed by #127
Closed

stacktrace: deconstructFunctionName returns bad output for methods #126

rhcarvalho opened this issue Dec 18, 2019 · 0 comments · Fixed by #127

Comments

@rhcarvalho
Copy link
Contributor

deconstructFunctionName puts .(Hub) (receiver) in frame.Module, but it should be a part of the function (method) name.

Originally posted by @kamilogorek in https://github.com/getsentry/sentry-go/pull/125/files#r359295441
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(stacktrace): Correctly report package names and ignore subpackages rhcarvalho/sentry-go
2 participants
@rhcarvalho @stephanie-anderson