Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make sure Remix SDK works without feature flags #8681

Closed
AbhiPrasad opened this issue Jul 31, 2023 · 2 comments · Fixed by #8940
Closed

Make sure Remix SDK works without feature flags #8681

AbhiPrasad opened this issue Jul 31, 2023 · 2 comments · Fixed by #8940
Assignees
@onurtemizkan
Labels
Package: remix Issues related to the Sentry Remix SDK

Comments

@AbhiPrasad
Copy link
Member

AbhiPrasad commented Jul 31, 2023 •
edited
Loading

https://github.com/remix-run/remix/commits/dev

As brought up in #7810 (comment), future flags are being removed when v2 actually releases. Let's test the SDK against the v2 branch of remix and check if they'll still work.
@AbhiPrasad AbhiPrasad added Meta: Help Wanted Package: remix Issues related to the Sentry Remix SDK labels Jul 31, 2023
@AbhiPrasad AbhiPrasad mentioned this issue Jul 31, 2023
Closed
@huw
Copy link

huw commented Jul 31, 2023

(Just FYI the actual work branch for v2 is dev)

@getsantry getsantry bot moved this to Waiting for: Product Owner in GitHub Issues with 👀 Jul 31, 2023
@AbhiPrasad
Copy link
Member Author

Thanks @huw!

@getsantry getsantry bot removed the status in GitHub Issues with 👀 Jul 31, 2023
@smeubank smeubank changed the title Make sure Remix SDK works without future flags Make sure Remix SDK works without feature flags Sep 4, 2023
@onurtemizkan onurtemizkan mentioned this issue Sep 8, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@onurtemizkan onurtemizkan

Labels
Package: remix Issues related to the Sentry Remix SDK
Projects
GitHub Issues with 👀
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(remix): Add Remix 2.x release support. getsentry/sentry-javascript
3 participants
@huw @onurtemizkan @AbhiPrasad