Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "git submodule update --init --recursive" in README #1078

Closed
pierricgimmig opened this issue Nov 12, 2024 · 1 comment · Fixed by #1091
Closed

Add "git submodule update --init --recursive" in README #1078

pierricgimmig opened this issue Nov 12, 2024 · 1 comment · Fixed by #1091

Comments

@pierricgimmig
Copy link

In the build section, it could be useful to add the git submodule update --init --recursive command before cmake -B build -DCMAKE_BUILD_TYPE=RelWithDebInfo. Also, maybe list system dependencies, I had to install libcurl4-openssl-dev for example.

@pierricgimmig
Copy link
Author

Also, the README states that "Building the Crashpad Backend requires a C++14 compatible compiler.", it seems it actually requires a C++ 17 compiler.

if(NOT CMAKE_CXX_STANDARD)
	set(CMAKE_CXX_STANDARD 17)
endif()

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants