Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tag length limit - 200 characters, shows only first, not documented #6576

Closed
tajchert opened this issue Nov 16, 2017 · 13 comments
Closed

Tag length limit - 200 characters, shows only first, not documented #6576

tajchert opened this issue Nov 16, 2017 · 13 comments

Comments

@tajchert
Copy link

  • Sentry 8.18.0
  • Docker

I try to log event with Android SDK (1.4.0) with tag that is over 200 characters long. I get:

"Discarded invalid value for parameter 'tags' " 
{
  "name": "tags",
  "value": [
    "test_tag_three",
    "aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa"
  ]
}

Question is - shouldn't be max length of tag documented (also maybe client SDK should throw runtime exception/warning for such case)?
Bug - web dashboard shows only one such case for event (if event has more than one such tag it reports only first one).

@bretthoerner
Copy link
Contributor

(Oops sorry about assign @mitsuhiko, ignore that.)

@tajchert We should document and warn about the tag length for sure. I don't understand your comment about the bug, though, can you provide more detail?

@tajchert
Copy link
Author

Hi,
No problem, glad to help with pointing that out.

With bug I mean if you have 2+ more tags that are over 200 characters, only first one is displayed in web dashboard as wrongly parsed, fix would be to display all tags that are not correct/doesn't meet criteria. If this is still not clear let me know.

@bretthoerner
Copy link
Contributor

bretthoerner commented Nov 17, 2017

Interesting, the JSON actually contains 2 errors, so I think this is a bug on the frontend.

I wonder if _.isEqual is not doing what I'd expect here: https://github.com/getsentry/sentry/blob/master/src/sentry/static/sentry/app/components/events/errors.jsx#L33



JSON:

@bretthoerner
Copy link
Contributor

@macqueen this may be another easy ticket? Error data in the payload but for some reason we're only showing the user one error? My comment above shows an example -- I sent an event with 2 very large tag values.

@ethanmdavidson
Copy link

ethanmdavidson commented Oct 29, 2019

Just ran into this same issue. The error message in the web dashboard is descriptive enough that I was able to track it down easily, but it would've been nicer to have a heads up in the documentation.

Not sure if the bug mentioned in this thread is still active, as I only had one tag that violated the length requirement.

@BYK
Copy link
Member

BYK commented Oct 29, 2019

Ping @markstory, @untitaker

@mitsuhiko
Copy link
Member

@BYK the error message should be more descriptive now compared to when this issue was first made. I feel like this might be resolved?

@mitsuhiko
Copy link
Member

Current error in the UI:

image

Maybe still not ideal

@yuzefovich
Copy link

One easy improvement to error message could be saying exactly what the "maximum length" is, so the users could act accordingly.

@github-actions
Copy link
Contributor

github-actions bot commented Jan 8, 2021

This issue has gone three weeks without activity. In another week, I will close it.

But! If you comment or otherwise update it, I will reset the clock, and if you label it Status: Accepted, I will leave it alone ... forever!


"A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀

@getsentry-release
Copy link

Routing to @getsentry/workflow for triage. ⏲️

@github-actions
Copy link
Contributor

This issue has gone three weeks without activity. In another week, I will close it.

But! If you comment or otherwise update it, I will reset the clock, and if you label it Status: Backlog or Status: In Progress, I will leave it alone ... forever!


"A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀

@scttcper
Copy link
Member

Docs on customizing tags specify the limits https://docs.sentry.io/platforms/node/enriching-events/tags/

@github-actions github-actions bot locked and limited conversation to collaborators Mar 26, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

9 participants