Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Mobile Replay SDK] Reduce number of Meta events being sent #70446

Open
Tracked by #74441
michellewzhang opened this issue May 7, 2024 · 4 comments
Open
Tracked by #74441

[Mobile Replay SDK] Reduce number of Meta events being sent #70446

michellewzhang opened this issue May 7, 2024 · 4 comments
Labels

Comments

@michellewzhang
Copy link
Member

michellewzhang commented May 7, 2024

We are receiving too many meta events from the SDK, which is contributing to some rrweb scrubbing bugs. To fix this, the SDK should reduce the meta events being sent to be:

  1. only at the very beginning of the replay (once per replay)
  2. only when the orientation changes

(note: the meta events being sent now are not causing bugs, but reducing the number will reduce the amount of data and reduce frontend computation. -- not a blocker, doesn't need to be high priority)

@michellewzhang michellewzhang changed the title [Mobile Replay SDK] Only send Meta events after [Mobile Replay SDK] Reduce number of Meta events being sent May 7, 2024
@brustolin
Copy link
Contributor

I didn't get this. What are meta events?

@michellewzhang
Copy link
Member Author

michellewzhang commented Aug 12, 2024

@brustolin they are type 4 events. usually, in web replays, they are only sent once at the beginning of the replay.

Image
Image

they provide meta info like height/width of the display.

@cmanallen
Copy link
Member

@michellewzhang @brustolin Still relevant?

@DaveRosenthalSentry
Copy link

I suspect this is not actually a bug, but rather is just the current intended behavior. Marking as feature request.

@linear linear bot added the Migrated label Jan 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants