Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(dynamic-sampling): zero-division error in transaction rebalance #83155

Merged
merged 3 commits into from
Jan 10, 2025
Merged

fix(dynamic-sampling): zero-division error in transaction rebalance #83155

merged 3 commits into from
Jan 10, 2025

Conversation

constantinius
Copy link
Contributor

Closes #82082

@constantinius constantinius requested a review from a team as a code owner January 9, 2025 12:34
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Jan 9, 2025
@constantinius constantinius requested a review from jan-auer January 9, 2025 12:35
@codecov Codecov
Copy link

codecov bot commented Jan 9, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 94.44444% with 1 line in your changes missing coverage. Please review.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...ic_sampling/tasks/boost_low_volume_transactions.py 50.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master   #83155      +/-   ##
==========================================
+ Coverage   87.57%   87.58%   +0.01%     
==========================================
  Files        9412     9441      +29     
  Lines      536989   536905      -84     
  Branches    21121    21121              
==========================================
- Hits       470248   470231      -17     
+ Misses      66375    66308      -67     
  Partials      366      366

obostjancic
obostjancic approved these changes Jan 9, 2025
View reviewed changes
Copy link
Member

@obostjancic obostjancic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@constantinius constantinius enabled auto-merge (squash) January 10, 2025 11:04
@constantinius constantinius merged commit decf6f4 into master Jan 10, 2025
49 checks passed
@constantinius constantinius deleted the constantinius/fix/dynamic-sampling/zero-division-error-transaction-rebalancing branch January 10, 2025 11:21
andrewshie-sentry pushed a commit that referenced this pull request Jan 22, 2025
@constantinius @andrewshie-sentry
fix(dynamic-sampling): zero-division error in transaction rebalance (#…
f73518c 
…83155)

Closes #82082
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@obostjancic obostjancic obostjancic approved these changes

@shellmayr shellmayr shellmayr approved these changes

@jan-auer jan-auer Awaiting requested review from jan-auer

Assignees
No one assigned
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ZeroDivisionError: float division by zero
3 participants
@constantinius @shellmayr @obostjancic