From bf366eb7205ce2bcd9de9254adbbe55f10b4b7d8 Mon Sep 17 00:00:00 2001
From: anthony sottile <anthony.sottile@sentry.io>
Date: Mon, 22 Jul 2024 16:46:48 -0400
Subject: [PATCH] ref: unify the signature of get_tag_values

---
 src/sentry/plugins/bases/tag.py                     | 2 +-
 src/sentry/plugins/sentry_interface_types/models.py | 2 +-
 src/sentry/plugins/sentry_urls/models.py            | 2 +-
 src/sentry/plugins/sentry_useragents/models.py      | 2 +-
 4 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/sentry/plugins/bases/tag.py b/src/sentry/plugins/bases/tag.py
index df1b40f513360c..0b523aa4e1f53c 100644
--- a/src/sentry/plugins/bases/tag.py
+++ b/src/sentry/plugins/bases/tag.py
@@ -10,7 +10,7 @@ class TagPlugin(Plugin2):
     tag: ClassVar[str]
     project_default_enabled = True
 
-    def get_tag_values(self, event, **kwargs):
+    def get_tag_values(self, event) -> list[str]:
         """
         Must return a list of values.
 
diff --git a/src/sentry/plugins/sentry_interface_types/models.py b/src/sentry/plugins/sentry_interface_types/models.py
index 29e2a6f3f1afcc..ca4e7d572d3ab7 100644
--- a/src/sentry/plugins/sentry_interface_types/models.py
+++ b/src/sentry/plugins/sentry_interface_types/models.py
@@ -17,5 +17,5 @@ class InterfaceTypePlugin(TagPlugin):
     tag = "interface_type"
     project_default_enabled = False
 
-    def get_tag_values(self, event):
+    def get_tag_values(self, event) -> list[str]:
         return [i.rsplit(".", 1)[-1] for i in event.interfaces.keys()]
diff --git a/src/sentry/plugins/sentry_urls/models.py b/src/sentry/plugins/sentry_urls/models.py
index 9f06e17d943fe3..9bc3bd7f57259e 100644
--- a/src/sentry/plugins/sentry_urls/models.py
+++ b/src/sentry/plugins/sentry_urls/models.py
@@ -16,7 +16,7 @@ class UrlsPlugin(TagPlugin):
     tag = "url"
     project_default_enabled = True
 
-    def get_tag_values(self, event):
+    def get_tag_values(self, event) -> list[str]:
         http = event.interfaces.get("request")
         if not http:
             return []
diff --git a/src/sentry/plugins/sentry_useragents/models.py b/src/sentry/plugins/sentry_useragents/models.py
index 1c209ef61221a2..0a0e9680fcf7e8 100644
--- a/src/sentry/plugins/sentry_useragents/models.py
+++ b/src/sentry/plugins/sentry_useragents/models.py
@@ -10,7 +10,7 @@ class UserAgentPlugin(TagPlugin):
     author_url = "https://github.com/getsentry/sentry"
     project_default_enabled = True
 
-    def get_tag_values(self, event):
+    def get_tag_values(self, event) -> list[str]:
         contexts = event.interfaces.get("contexts")
         # disable tagging if contexts are present
         if contexts: