-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bucket and files fxns should return data frames #11
Comments
@seankross With what's on main branch right now, all the inputs to our file fxns are now vectorized. however, this issue is about returning data frames from file and bucket fxns. The vectorized nature of the file fxns makes it easy - as pointed out in the I think it's easier to think about always returning dfs with bucket fxns |
For the file fxns I think it's mostly okay to be dealing in vectors because ultimately you're acting on and pushing around paths. Where in the case of this is a poorly formed thought: |
Thanks for your feedback. ON your last thought, that makes sense. Fxns in this package may not be piped together themselves - more likely the output of a fxn in this pkg will go into a tidyverse pipeline |
Originally via @seankross in #3 (review)
The text was updated successfully, but these errors were encountered: