Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why is it not published on crates.io? #392

Closed
icefoxen opened this issue Aug 30, 2018 · 6 comments
Closed

Why is it not published on crates.io? #392

icefoxen opened this issue Aug 30, 2018 · 6 comments

Comments

@icefoxen
Copy link

Sorry if this is a common question, but I couldn't find it in the issue tracker. It seems like publishing on crates.io would make gutenberg a lot easier to install from source, since you would just have to do cargo install gutenberg to get the latest version.

@caemor
Copy link
Contributor

caemor commented Aug 30, 2018

See #117 and https://www.vincentprouillet.com/blog/releasing-gutenberg-0-1-0/

afaik his main reasons were:

  • the inclusion of sass makes compiling a little bit more difficult
  • usage of a cargo workspace with many small packages so he would need to upload many small additional packages to crates.io

@Keats
Copy link
Collaborator

Keats commented Aug 30, 2018

Exactly what @caemor said.
Cargo now ships Cargo.lock for binaries so it would break less than before but it isn't trivial to build on Windows due to 2 C/C++ dependencies (libsass and oniguruma).

The main reason though is the use of cargo workspaces to speed up compilation and I don't want to upload/maintain ~10 crates (and increasing) for cargo install just to have it work. An ideal solution would be to have a way to tell Cargo to ignore workspaces when publishing and just put everything into one crate somehow.

@icefoxen
Copy link
Author

icefoxen commented Aug 30, 2018

Thank you! That makes sense. Though my bias forces me to say "you know if it was all one crate life would be simpler all around..." Multiple subcrates for compilation speed is a hack that should be made obsolete by incremental compilation. In a perfect world. :sigh:

C dependencies is a bit more of a mixed bag, but I can definitely sympathize with not wanting to deal with that either.

@icefoxen
Copy link
Author

Actually I was pointed at an interesting proposal lately: https://internals.rust-lang.org/t/multiple-libraries-in-a-cargo-project/8259

@Keats
Copy link
Collaborator

Keats commented Sep 2, 2018

Multiple subcrates for compilation speed is a hack that should be made obsolete by incremental compilation. In a perfect world. :sigh:

Incremental compilation is definitely an improvement but with a somewhat old machine like mine it is still too slow. If the compiler gets fasted, I might move back subcrates as modules instead though.

For the C libraries, hopefully syntect will have an option to use fancy-regex soon (trishume/syntect#34). That still leaves libsass (which also seems to prevent having a musl target for gutenberg apparently) but I have big hopes for https://github.com/kaj/rsass

@Keats
Copy link
Collaborator

Keats commented Sep 6, 2018

This is not going to happen for a while so closing it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants