New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clipping demo doesn't work for triangles with 1 or 2 vertices outside of the clipping plane #30

Open

prcastro opened this issue Apr 25, 2023 · 1 comment

prcastro commented Apr 25, 2023

It seems to be simply uninplemented

computer-graphics-from-scratch/demos/raster-09.html

Lines 354 to 358 in 862327b

    
           } else if (in_count == 1) { 
        
             // The triangle has one vertex in. Output is one clipped triangle. 
        
           } else if (in_count == 2) { 
        
             // The triangle has two vertices in. Output is two clipped triangles. 
        
           }

Owner

ggambetta commented Apr 26, 2023

You're right, thanks for bringing this up. I'll add the missing code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment