Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Misc. bug: gguf pypy package dumps /scripts/ and /examples/ into site-packages #11089

Open
Ph0rk0z opened this issue Jan 5, 2025 · 4 comments · May be fixed by #11116
Open

Misc. bug: gguf pypy package dumps /scripts/ and /examples/ into site-packages #11089

Ph0rk0z opened this issue Jan 5, 2025 · 4 comments · May be fixed by #11116

Comments

@Ph0rk0z
Copy link

Ph0rk0z commented Jan 5, 2025

Name and Version

https://pypi.org/project/gguf/ latest

Operating systems

Linux

Which llama.cpp modules do you know to be affected?

Other (Please specify in the next section)

Problem description & steps to reproduce

do a pip install gguf inside of a conda env. Now the package has created both a /scripts/ and an /examples/ inside your site-packages.

I'm not sure it's particular to my environment, but running any other project with a /scripts/ folder has a relatively high chance of trying to import from GGUF "scripts" instead of it's own folder, at least on py 3.10.

If there is any other reason this happens, let me know. I have now checked 2 environments where I had to install GGUF and both have this issue. The solution is to simply delete the offending folders but you now have lost the scripts. Should they not be in the gguf folder so that it's gguf/scripts?

First Bad Commit

No response

Relevant log output

No response

@ggerganov
Copy link
Owner

I don't think this is intended. Moving these folders under gguf should be correct.

@Ph0rk0z
Copy link
Author

Ph0rk0z commented Jan 6, 2025

Who do I bug about the package?

@VJHack VJHack linked a pull request Jan 7, 2025 that will close this issue
@VJHack
Copy link
Contributor

VJHack commented Jan 7, 2025

I raised the PR to move the scripts folder, however I'm not familiar with how these Python packages get published to PyPI.

@ggerganov
Copy link
Owner

I raised the PR to move the scripts folder, however I'm not familiar with how these Python packages get published to PyPI.

After merging the PR, we'll tag the commit and the Github workflow will make a new release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants