Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

llava: batch inference #4378

Closed
Borobo opened this issue Dec 8, 2023 · 5 comments
Closed

llava: batch inference #4378

Borobo opened this issue Dec 8, 2023 · 5 comments
Labels

Comments

@Borobo
Copy link

Borobo commented Dec 8, 2023

Hello!

I'm using llava with the server and I'm wondering if anyone is working on batch inference by batching llava's clip or not. If not, I would be happy to contribute as this feature could be very useful to speed up inference time for llava.
As i'm new in this wonderful repo, I would also be grateful if you could guide me for the first steps (what file do I have to edit)

Thanks you in advance!

@cmp-nct
Copy link
Contributor

cmp-nct commented Dec 8, 2023

Afaik FSSRepo was working on offloading CLIP properly to GPU, there is a PR for that already but it was missing some ggml cuda upgrades (broadcasting features I think).

Currently it runs on CPU only which is a massive slowdown, I don't think parallel processing would help in any way on CPU. But of course on GPU it's a different story.

@Borobo
Copy link
Author

Borobo commented Dec 12, 2023

So I guess I'll have to wait until this PR is merged before considering clip batching functionality, as I'm not very familiar with ggml structures. I'm going to keep an eye on it, thanks for you reply!

@y10ab1
Copy link
Contributor

y10ab1 commented Dec 17, 2023

We can track the PR ggerganov/llama.cpp/pull/4205.
It appears that the corresponding pull request at ggerganov/ggml/pull/621 has been merged.
I guess there may be progress soon.

@KohakuBlueleaf
Copy link

Is there any updates for this feature?

@github-actions github-actions bot added the stale label Apr 6, 2024
Copy link
Contributor

This issue was closed because it has been inactive for 14 days since being marked as stale.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants