fix get_num_physical_cores() #1436
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
had been broken on complex topologies because "cpu cores" in /proc/cpuinfo is per-"physical id"
slaren
approved these changes
May 13, 2023
slaren
reviewed
May 15, 2023
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| siblings.insert(line); | ||
| } | ||
| } | ||
| if (siblings.size() > 0) { |
There was a problem hiding this comment.
warning: the 'empty' method should be used to check for emptiness instead of 'size' [readability-container-size-empty]
Suggested change
| if (siblings.size() > 0) { | |
| if (!siblings.empty()) { |
Additional context
/usr/include/c++/11/bits/unordered_set.h:298: method 'unordered_set'::empty() defined here
empty() const noexcept
^
DDEle
reviewed
Dec 1, 2023
| // enumerate the set of thread siblings, num entries is num cores | ||
| std::unordered_set<std::string> siblings; | ||
| for (uint32_t cpu=0; cpu < UINT32_MAX; ++cpu) { | ||
| std::ifstream thread_siblings("/sys/devices/system/cpu" |
There was a problem hiding this comment.
I think it should be "/sys/devices/system/cpu/cpu" + std::to_string(cpu) + "/topology/thread_siblings") ?
There was a problem hiding this comment.
Yup, do you want to open a PR with fix?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
had been broken on complex topologies because "cpu cores" in /proc/cpuinfo is per-"physical id"