Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Web Chat server does not properly escape HTML output #2300

Closed
4 tasks done
coder543 opened this issue Jul 20, 2023 · 1 comment · Fixed by #2368
Closed
4 tasks done

Web Chat server does not properly escape HTML output #2300

coder543 opened this issue Jul 20, 2023 · 1 comment · Fixed by #2368
Assignees

Comments

@coder543
Copy link

coder543 commented Jul 20, 2023

Prerequisites

Please answer the following questions for yourself before submitting an issue.

  • I am running the latest code. Development is very rapid so there are no tagged versions as of now.
  • I carefully followed the README.md.
  • I searched using keywords relevant to my issue to make sure that I am creating a new issue that is not already open (or closed).
  • I reviewed the Discussions, and have a new bug or useful enhancement to share.

Expected Behavior

When Llama 2 generates code as output, it should not be rendered in the chat output, since that both defies expectations and renders the code unreadable.

Current Behavior

it renders an inline dropdown element, instead of showing the code:

image

Steps to Reproduce

  1. Ask Llama 2 to generate some kind of HTML
  2. The HTML that it generates will be rendered inline instead of written as a code block

I followed these instructions to get the web chat working, and it seems to work great as long as no HTML is being emitted by the model.

@SlyEcho SlyEcho self-assigned this Jul 24, 2023
@SlyEcho SlyEcho linked a pull request Jul 24, 2023 that will close this issue
@Green-Sky
Copy link
Collaborator

fun in its own regard. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants