Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Single Quote causing issue #3

Closed
urielzen opened this issue Nov 7, 2018 · 5 comments
Closed

Single Quote causing issue #3

urielzen opened this issue Nov 7, 2018 · 5 comments
Assignees
Labels
bug Something isn't working

Comments

@urielzen
Copy link

urielzen commented Nov 7, 2018

A single quote is making the characters after it look like a string

image

Also the "." or "?" characters are not showing purple like it says it the documentation they should be.
I have Dark+ theme (I think is the default one when I installed VSCode)
Thank u so much for this extension

@ghaschel
Copy link
Owner

ghaschel commented Nov 7, 2018

I will take a look at this. thank you for reporting it.

About the operators, I think it is a limitation of the default theme. I currently am using dark-plus-syntax. It's the same as the default one, but it have some improvements. Can you confirm me that changing theme solves the '?', '.', and '!' issue?

@ghaschel ghaschel added the bug Something isn't working label Nov 8, 2018
@ghaschel ghaschel self-assigned this Nov 8, 2018
@ghaschel
Copy link
Owner

ghaschel commented Nov 8, 2018

Issue with single quote fixed with 0.0.22. I will wait for your answer about the '?', '!' and '.' before closing the issue.

@urielzen
Copy link
Author

urielzen commented Nov 8, 2018

Thank u for fixing the bug. And you are correct, After installing the dark plus syntax theme, the operators show with purple color.

If you don't mind, can I ask about the decisions to use orange/red for the < /> characters in tags? I have a tendency to get distracted by the red color thinking that is some kind of lint error.

Thanks again.

@ghaschel
Copy link
Owner

ghaschel commented Nov 8, 2018

Sure you can. Actually i didn't choose colors, just the scope names (in this case, i choose the same as the regex one because it is easier to see regex highlighting in themes).

But now that you have pointed it out, it makes sense. It does looks like some sort of linting error.

I think it's best to return it to the default color to keep it similar to other HTML highlithing aswell.

@ghaschel
Copy link
Owner

ghaschel commented Nov 8, 2018

Color fixed in 0.0.23 =]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants