Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Valid component names can break highlighting #48

Closed
AlexsaniKY opened this issue May 3, 2022 · 4 comments
Closed

Valid component names can break highlighting #48

AlexsaniKY opened this issue May 3, 2022 · 4 comments
Assignees
@ghaschel
Labels
bug Something isn't working

Comments

@AlexsaniKY
Copy link

Syntax highlighting is broken when certain strings are used in the name. Using a custom angular component starting with 'style' causes all template highlighting to stop from that point onwards in the file.

Example: <style-preview-component></style-preview-component> would highlight the substrings 'style', '-preview-componen', 't' separately, and then break template highlighting for the rest of the template document.
image
@AlexsaniKY
Copy link
Author

It does not resume highlighting until it sees a 'style' closing tag, despite that being malformed html (closing a tag that was never opened)

@ghaschel
Copy link
Owner

ghaschel commented May 3, 2022

I'm on it!

@ghaschel ghaschel self-assigned this May 3, 2022
@ghaschel ghaschel added the bug Something isn't working label May 3, 2022
@ghaschel
Copy link
Owner

ghaschel commented May 3, 2022

The update is live now https://marketplace.visualstudio.com/items?itemName=ghaschel.vscode-angular-html

@AlexsaniKY
Copy link
Author

Fantastic. I like this extension for my workflow, nice turnaround.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ghaschel ghaschel

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ghaschel @AlexsaniKY