Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Item Tags #155

Open
Jophire opened this issue Sep 30, 2024 · 2 comments
Open

Item Tags #155

Jophire opened this issue Sep 30, 2024 · 2 comments

Comments

@Jophire
Copy link

Jophire commented Sep 30, 2024

Some tags with default values would also go a long way to making it easy to add items through datapacks. The config is nice, but its starting to look a bit messy with how long the list is getting.

Something like:
very_dehydrating(-15), dehydrating(-10), slightly_dehydrating(-5), slightly_hydrating(+5), hydrating(+10), very_hydrating(+15).
very_parching(-24), parching(-16), slightly_parching(-8), slightly_quenching(+8), quenching(+16), very_quenching(+24).

Values to be modified of course.

This also means you would be able to search for food and drink items based off of the tag.

Examples will be added as I think of them.

Cinnamon Powder: very_parching (Would also make for a funny advancement in the datapack.)
Salt Water: slightly_dehydrating, quenching
Sports Drink: very_hydrating, quenching

@mlus-asuka
Copy link
Contributor

image
this is available if you do like this

@Jophire
Copy link
Author

Jophire commented Oct 28, 2024

Doesn't quite work how I was looking for it to.
With that method, you can't separate the quench and hydrate values, and applying two such tags to an item will cause the last tag to overwrite the rest.

ex: If we have these tags, and apply both to one item.
#minecraft:very_quench, 0, 5
#minecraft:very_hydrate, 5, 0

Only the last tag registered will apply, so instead of having a Sports Drink with a quench and hydrate value of 5. We have a sports drink with either a quench or hydrate value of 5.

Now, what you posted still helps, cause it does mean I can do something like #minecraft:smoothie,2,6 and then tag all the smoothies, but I would rather just tag all the smoothies #slightly_hydrating, #quenching.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants