fix: Virtual Scroll not working on large dataset w/HTML render enabled, fixes #203 #204
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
ghiscoding
commented
Jan 31, 2024
•
ghiscoding
commented
- fixes issue multiple-select items disappear after upgrading from slickgrid-react 3.3.2 to slickgrid-react 4.3.1 #203
- the issue was only showing up when the user had any of the render HTML option(s) enabled to render label text as HTML
- this PR adds an extra select to Example 10 (Large Select) with HTML rendering in order to test the bug fix and also have E2E tests covering it as well (as shown below)
ghiscoding
changed the title
ghiscoding
changed the title
ghiscoding
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.