Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: provide PubSub to SlickGrid/DataView avoid looping all events #401

Merged
merged 1 commit into from
Aug 31, 2024

Conversation

ghiscoding
Copy link
Owner

@ghiscoding ghiscoding commented Aug 31, 2024

  • SlickGrid/SlickDataView allow passing a PubSub in latest major release v5.0 but this change was never applied in Slickgrid-React (though it was applied in all other ports) because I couldn't get it working at first and I had decided to put this aside, but after revisiting this now, I am able to implement the change which will help with perf as describe below
  • the perf change is that we no longer need to loop through all SlickGrid/DataView and subscribe to all of the events to then dispatch whenever it triggers, that was the previous approach and wasn't ideal. The new approach is to simply pass the PubSub to both SlickGrid/DataView and let them dispatch whenever necessary without requiring any loop whatsoever

Copy link

stackblitz bot commented Aug 31, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@ghiscoding ghiscoding merged commit 474f4ba into master Aug 31, 2024
4 checks passed
@ghiscoding ghiscoding deleted the perf/slickgrid-pubsub branch August 31, 2024 05:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant