-
Notifications
You must be signed in to change notification settings - Fork 231
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ES6 import #36
Comments
@nlemoine Hey, I'm not sure if that would be possible as we have to maintain compatibility with ES6 as well. You can use a babel transform with your Browserify. This should help you out - https://github.com/babel/babelify Closing this for now, as ES6 imports already work. Feel free to let know if you face difficulties. |
Thanks for your feedback. I'm already using babelify (my project code is ES6) but I'm having the same issue described here: babel/babelify#247 I think you can keep your original code in ES6 and provide multiple versions allowing developers to select the one depending on their environment. See: https://medium.com/@tarkus/how-to-build-and-publish-es6-modules-today-with-babel-and-rollup-4426d9c7ca71 Anyway, I fixed my issue for now using the dist version: |
@ghosh Please see: https://github.com/rollup/rollup-plugin-babel#external-dependencies Would you consider reopening the issue? |
@nlemoine Thanks for the update and the relevant documentation. Will look into it. |
Thanks for considering the request! 👍 |
In package.json
I think
main
should provide the non ES6 version of micromodal (dist/micromodal.min.js
). I have some errors bundling it with browserify.The text was updated successfully, but these errors were encountered: