Skip to content
This repository has been archived by the owner on Oct 4, 2024. It is now read-only.

Handle Intermittent Google Service failures #99

Closed
gilesknap opened this issue Jul 31, 2019 · 6 comments
Closed

Handle Intermittent Google Service failures #99

gilesknap opened this issue Jul 31, 2019 · 6 comments
Assignees

Comments

@gilesknap
Copy link
Owner

The Google service has bugs which means some items can never download, attempts to access the media IDs gets a 500 error. We place offending items in the gphotos.bad_ids.yaml.

However, it is important to distinguish between this and intermittent service failure (as far as is possible anyway). See #98 (comment) for more discussion.

@gilesknap gilesknap added this to the Next Issues to Address milestone Jul 31, 2019
@gilesknap gilesknap self-assigned this Jul 31, 2019
@gilesknap
Copy link
Owner Author

Since https://issuetracker.google.com/issues/116842164 has now been fixed we could probably retire the bad_ids logic and exit with an error if retries fail to download a file.

@gilesknap
Copy link
Owner Author

TODO: disable bad_id logic (but keep the code so it can be switched on again easily )

@gilesknap
Copy link
Owner Author

See #125 - maybe people are still getting 500s so it is still useful to have the BadIds logic.

This means we need to distinguish between

  • Null response in mediaItems.batchGet
  • 500 errors

However, I think there are sometimes intermittent 500s in which case there is no solution.

@gilesknap
Copy link
Owner Author

If the cause of bad ids has now been fixed (see https://issuetracker.google.com/issues/141255600#comment8)
it is time to remove the BadIds handling, then always report errors.

@gilesknap
Copy link
Owner Author

https://issuetracker.google.com/issues/141255600 is fixed - I will remove bad ids feature

@gilesknap gilesknap modified the milestones: Next Issues to Address, Next Release Nov 17, 2019
@gilesknap
Copy link
Owner Author

Bad ids feature removed. Thus in future, intermittent failures will be reported but have no effect on future runs.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant