-
Notifications
You must be signed in to change notification settings - Fork 169
Handle Intermittent Google Service failures #99
Comments
Since https://issuetracker.google.com/issues/116842164 has now been fixed we could probably retire the bad_ids logic and exit with an error if retries fail to download a file. |
TODO: disable bad_id logic (but keep the code so it can be switched on again easily ) |
See #125 - maybe people are still getting 500s so it is still useful to have the BadIds logic. This means we need to distinguish between
However, I think there are sometimes intermittent 500s in which case there is no solution. |
If the cause of bad ids has now been fixed (see https://issuetracker.google.com/issues/141255600#comment8) |
https://issuetracker.google.com/issues/141255600 is fixed - I will remove bad ids feature |
Bad ids feature removed. Thus in future, intermittent failures will be reported but have no effect on future runs. |
The Google service has bugs which means some items can never download, attempts to access the media IDs gets a 500 error. We place offending items in the gphotos.bad_ids.yaml.
However, it is important to distinguish between this and intermittent service failure (as far as is possible anyway). See #98 (comment) for more discussion.
The text was updated successfully, but these errors were encountered: