-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fixed base urls for HereMaps #28
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You're probably not done yet, still my 2c. Also you can actually remove self.base_url
entirely, no function will use it anymore
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the last minor stuff and we're good. no need for another review round. you can just fix the few things and merge yourself, I'll approve now.
passes modified base urls for HereMaps'
.directions()
,isochrones()
andmatrix()
methods to the instance's client