Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed base urls for HereMaps #28

Merged
merged 7 commits into from
Jun 24, 2021
Merged

fixed base urls for HereMaps #28

merged 7 commits into from
Jun 24, 2021

Conversation

chrstnbwnkl
Copy link
Contributor

passes modified base urls for HereMaps' .directions(), isochrones() and matrix() methods to the instance's client

@chrstnbwnkl chrstnbwnkl requested a review from nilsnolde June 23, 2021 15:25
Copy link
Owner

@nilsnolde nilsnolde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're probably not done yet, still my 2c. Also you can actually remove self.base_url entirely, no function will use it anymore

routingpy/routers/heremaps.py Outdated Show resolved Hide resolved
routingpy/routers/heremaps.py Outdated Show resolved Hide resolved
routingpy/routers/heremaps.py Outdated Show resolved Hide resolved
@chrstnbwnkl chrstnbwnkl requested a review from nilsnolde June 24, 2021 11:03
Copy link
Owner

@nilsnolde nilsnolde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the last minor stuff and we're good. no need for another review round. you can just fix the few things and merge yourself, I'll approve now.

CHANGELOG.md Outdated Show resolved Hide resolved
routingpy/routers/heremaps.py Outdated Show resolved Hide resolved
routingpy/routers/heremaps.py Outdated Show resolved Hide resolved
@chrstnbwnkl chrstnbwnkl merged commit 3559869 into master Jun 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants