Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose metrics for Prometheus Monitoring Framework? #1190

Open
goettl79 opened this issue Jan 26, 2017 · 7 comments
Open

Expose metrics for Prometheus Monitoring Framework? #1190

goettl79 opened this issue Jan 26, 2017 · 7 comments

Comments

@goettl79
Copy link

Hi,

Anybody interested to expose gitblit metrics for the prometheus framework (prometheus.io). Would be a quick win I think. At least some basic metrics would be fine. E.g. Garbage Collections, Pushes / Pulls / Clone durations and so on...

@gitblit
Copy link
Collaborator

gitblit commented Jan 26, 2017

Hi @goettl79. That's certainly a great suggestion. Gitblit doesn't currently track many/any stats now. It could be instrumented for metrics collection, of course. Is this something you'd be interested in contributing? I have had success using DropWizard Metrics to report to monitoring systems in other projects. Do you know if there is a Prometheus adapter for Metrics? Or would it require a one-off integration with Prometheus?

@goettl79
Copy link
Author

I would be interested in contributing this feature, probably following the approach taken here: prometheus/client_java#101.

Didn't know that gitblit is dropwizard service. Btw. Dropwizward Metrics do not export gitblit specific metrics, but only general service metrics to my knowledge.

@gitblit
Copy link
Collaborator

gitblit commented Jan 31, 2017

Didn't know that gitblit is dropwizard service.

It is not, you misunderstood.

@goettl79
Copy link
Author

Ah, ok. Then I'll see how far I get using the standard prometheus java client. Will add a pull request as soon as possible.

@goettl79
Copy link
Author

I implemented a first version of the metrics in pull request #1230 . @gitblit @fzs you can inspect the metrics on https://localhost:8443/prometheus/.

Next to default metrics for the jvm and log4j I implemented two metrics for git_garbage_collection and ldap sync time. ldap sync time is only visible when ldap is configured.

@goettl79
Copy link
Author

goettl79 commented Jun 22, 2017

Hi @gitblit @fzs, anything I can do to advance this issue?

@flaix
Copy link
Member

flaix commented Nov 19, 2022

I wonder if this would also be possible through OpenTelemetry. I would like to have some adoption measurements and was planning to use OTeL for that.
Having two separate observability systems seems overkill. On the other hand, Prometheus seems to come with many default libraries so not much needs to be done.
It might still be nice to have system that allows for push and pull exporters, and OTeL has a Prometheus exporter. But that is classified as experimental.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants