Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*AxisLineShow options do not work #231

Closed
mconlin opened this issue Nov 8, 2017 · 2 comments
Closed

*AxisLineShow options do not work #231

mconlin opened this issue Nov 8, 2017 · 2 comments
Assignees
Milestone

Comments

@mconlin
Copy link
Contributor

mconlin commented Nov 8, 2017

It appears that both the catAxisLineShow and valAxisLineShow options don't change anything when generating a chart. True or false, the axis lines will always show up.

Looking at the source code for building the axes, I couldn't find any reference to these options. Maybe I'm missing something, but it seems like functionality might have been lost somewhere along the line with regard to these options.

There are some working options that produce a result that is close to what is desired.
catAxisHidden, for example, does indeed hide the axis line, but it also hides the category text at the same time, which is not desired.

@mconlin
Copy link
Contributor Author

mconlin commented Nov 8, 2017

I've created a pull request with a potential fix: #232

@gitbrent gitbrent self-assigned this Nov 9, 2017
gitbrent pushed a commit that referenced this issue Nov 14, 2017
@gitbrent gitbrent added this to the 1.10.0 milestone Nov 14, 2017
@gitbrent
Copy link
Owner

Thanks @mconlin! The Issue has been fixed in the current codebase.

These options were indeed lost in a past merge.

ericrockey pushed a commit to WeTransfer/PptxGenJS that referenced this issue Mar 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants