-
Notifications
You must be signed in to change notification settings - Fork 61.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
workflows: Add link to skipped action workaround #16173
workflows: Add link to skipped action workaround #16173
Conversation
Actions that are skipped because of path filtering remain pending as required on pull requests if they are set as required checks. Since the required checks branch protection feature does not have a notion of unnecessary checks a workaround is required. This workaround is documented but hard to find so I added a note pointing to it from the section that introduces path filtering for workflows. Fixes github#16048
Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines. |
How long do I need to wait for the "Automatically generated comment"? Does it not get generated for draft PRs? |
@toonn Ah, that's a great catch. I didn't know the PR has to be "ready for review" for the auto generated comment. I will add that clarity in the PR template. You can view your changes by clicking the "show environments" and "view deployment" button on the PR feed when the PR is in draft mode. |
A stale label has been added to this pull request because it has been open 7 days with no activity. To keep this PR open, add a comment or push a commit within 3 days. |
I think my side of this is fulfilled, waiting for a reaction. |
@toonn Thanks for the comment. Could you please leave a comment next time when you convert your draft PR to ready for review? That way I will get notified and get this triaged 💖. Thank you for opening this PR, I will get this triaged for a review ✨ |
data/reusables/actions/workflows/section-triggering-a-workflow-paths.md
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for this addition, @toonn! It will make that info easier to find. I've made a few edits, and will merge this in.
Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues ⚡ |
Actions that are skipped because of path filtering remain pending as
required on pull requests if they are set as required checks. Since the
required checks branch protection feature does not have a notion of
unnecessary checks a workaround is required.
This workaround is documented but hard to find so I added a note
pointing to it from the section that introduces path filtering for
workflows.
Fixes #16048
Why:
Closes issue link
What's being changed:
Check off the following:
Writer impact (This section is for GitHub staff members only):