From b28b87b789cfc550d70c844a7f6244a2dff0073a Mon Sep 17 00:00:00 2001 From: djdefi Date: Wed, 14 Oct 2020 12:38:55 -0700 Subject: [PATCH 1/8] specify ssh shell Specify that the command should be run within the administrative SSH shell, and link to the relevant document for access. --- ...s-for-vulnerable-dependencies-on-github-enterprise-server.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/content/admin/configuration/enabling-alerts-for-vulnerable-dependencies-on-github-enterprise-server.md b/content/admin/configuration/enabling-alerts-for-vulnerable-dependencies-on-github-enterprise-server.md index bcc57d5406a1..b48fa2acc126 100644 --- a/content/admin/configuration/enabling-alerts-for-vulnerable-dependencies-on-github-enterprise-server.md +++ b/content/admin/configuration/enabling-alerts-for-vulnerable-dependencies-on-github-enterprise-server.md @@ -41,7 +41,7 @@ Before enabling {% if currentVersion ver_gt "enterprise-server@2.21" %}{% data v {% endif %} {% data reusables.enterprise_site_admin_settings.sign-in %} -1. In the administrative shell, enable the {% if currentVersion ver_gt "enterprise-server@2.21" %}{% data variables.product.prodname_dependabot_short %}{% else %}security{% endif %} alerts for vulnerable dependencies on {% data variables.product.product_location_enterprise %}: +1. In the [administrative SSH shell](/enterprise/{{ currentVersion }}/admin/configuration/accessing-the-administrative-shell-ssh#enabling-access-to-the-administrative-shell-via-ssh), enable the {% if currentVersion ver_gt "enterprise-server@2.21" %}{% data variables.product.prodname_dependabot_short %}{% else %}security{% endif %} alerts for vulnerable dependencies on {% data variables.product.product_location_enterprise %}: ``` shell $ ghe-dep-graph-enable ``` From e8d012014001ee4653475d69feb618fbbca4aaf4 Mon Sep 17 00:00:00 2001 From: djdefi Date: Mon, 19 Oct 2020 09:16:32 -0700 Subject: [PATCH 2/8] Link to SSH doc as a note --- ...-vulnerable-dependencies-on-github-enterprise-server.md | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/content/admin/configuration/enabling-alerts-for-vulnerable-dependencies-on-github-enterprise-server.md b/content/admin/configuration/enabling-alerts-for-vulnerable-dependencies-on-github-enterprise-server.md index b48fa2acc126..6560f7a7602c 100644 --- a/content/admin/configuration/enabling-alerts-for-vulnerable-dependencies-on-github-enterprise-server.md +++ b/content/admin/configuration/enabling-alerts-for-vulnerable-dependencies-on-github-enterprise-server.md @@ -41,10 +41,15 @@ Before enabling {% if currentVersion ver_gt "enterprise-server@2.21" %}{% data v {% endif %} {% data reusables.enterprise_site_admin_settings.sign-in %} -1. In the [administrative SSH shell](/enterprise/{{ currentVersion }}/admin/configuration/accessing-the-administrative-shell-ssh#enabling-access-to-the-administrative-shell-via-ssh), enable the {% if currentVersion ver_gt "enterprise-server@2.21" %}{% data variables.product.prodname_dependabot_short %}{% else %}security{% endif %} alerts for vulnerable dependencies on {% data variables.product.product_location_enterprise %}: +1. In the administrative shell, enable the {% if currentVersion ver_gt "enterprise-server@2.21" %}{% data variables.product.prodname_dependabot_short %}{% else %}security{% endif %} alerts for vulnerable dependencies on {% data variables.product.product_location_enterprise %}: ``` shell $ ghe-dep-graph-enable ``` +{{#note}} +**Note**: For more information about enabling access to the administrative shell via SSH, see "[Accessing the administrative shell (SSH) +](/enterprise/{{ currentVersion }}/admin/configuration/accessing-the-administrative-shell-ssh)." +{{/note}} + 3. Return to {% data variables.product.prodname_ghe_server %}. {% data reusables.enterprise_site_admin_settings.access-settings %} {% data reusables.enterprise_site_admin_settings.business %} From e5d47d4597afb31988fda4cbfdf878eb46f3e96f Mon Sep 17 00:00:00 2001 From: djdefi Date: Mon, 19 Oct 2020 11:03:42 -0700 Subject: [PATCH 3/8] note syntrax --- ...for-vulnerable-dependencies-on-github-enterprise-server.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/content/admin/configuration/enabling-alerts-for-vulnerable-dependencies-on-github-enterprise-server.md b/content/admin/configuration/enabling-alerts-for-vulnerable-dependencies-on-github-enterprise-server.md index 6560f7a7602c..1c91fce4f076 100644 --- a/content/admin/configuration/enabling-alerts-for-vulnerable-dependencies-on-github-enterprise-server.md +++ b/content/admin/configuration/enabling-alerts-for-vulnerable-dependencies-on-github-enterprise-server.md @@ -45,10 +45,10 @@ Before enabling {% if currentVersion ver_gt "enterprise-server@2.21" %}{% data v ``` shell $ ghe-dep-graph-enable ``` -{{#note}} +{% note %} **Note**: For more information about enabling access to the administrative shell via SSH, see "[Accessing the administrative shell (SSH) ](/enterprise/{{ currentVersion }}/admin/configuration/accessing-the-administrative-shell-ssh)." -{{/note}} +{% endnote %} 3. Return to {% data variables.product.prodname_ghe_server %}. {% data reusables.enterprise_site_admin_settings.access-settings %} From 67088a2be9506bb385eb101737e7ceec602aad5c Mon Sep 17 00:00:00 2001 From: djdefi Date: Mon, 19 Oct 2020 12:00:06 -0700 Subject: [PATCH 4/8] remove extra space --- ...-for-vulnerable-dependencies-on-github-enterprise-server.md | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/content/admin/configuration/enabling-alerts-for-vulnerable-dependencies-on-github-enterprise-server.md b/content/admin/configuration/enabling-alerts-for-vulnerable-dependencies-on-github-enterprise-server.md index 1c91fce4f076..d5e5ab5a0d62 100644 --- a/content/admin/configuration/enabling-alerts-for-vulnerable-dependencies-on-github-enterprise-server.md +++ b/content/admin/configuration/enabling-alerts-for-vulnerable-dependencies-on-github-enterprise-server.md @@ -46,8 +46,7 @@ Before enabling {% if currentVersion ver_gt "enterprise-server@2.21" %}{% data v $ ghe-dep-graph-enable ``` {% note %} -**Note**: For more information about enabling access to the administrative shell via SSH, see "[Accessing the administrative shell (SSH) -](/enterprise/{{ currentVersion }}/admin/configuration/accessing-the-administrative-shell-ssh)." +**Note**: For more information about enabling access to the administrative shell via SSH, see "[Accessing the administrative shell (SSH)](/enterprise/{{ currentVersion }}/admin/configuration/accessing-the-administrative-shell-ssh)." {% endnote %} 3. Return to {% data variables.product.prodname_ghe_server %}. From 11e4ac64a37681002c16a37f434f649c89fd6250 Mon Sep 17 00:00:00 2001 From: djdefi Date: Wed, 21 Oct 2020 09:50:41 -0700 Subject: [PATCH 5/8] Update content/admin/configuration/enabling-alerts-for-vulnerable-dependencies-on-github-enterprise-server.md Co-authored-by: hubwriter <54933897+hubwriter@users.noreply.github.com> --- ...s-for-vulnerable-dependencies-on-github-enterprise-server.md | 2 ++ 1 file changed, 2 insertions(+) diff --git a/content/admin/configuration/enabling-alerts-for-vulnerable-dependencies-on-github-enterprise-server.md b/content/admin/configuration/enabling-alerts-for-vulnerable-dependencies-on-github-enterprise-server.md index d5e5ab5a0d62..56bcaa5ee068 100644 --- a/content/admin/configuration/enabling-alerts-for-vulnerable-dependencies-on-github-enterprise-server.md +++ b/content/admin/configuration/enabling-alerts-for-vulnerable-dependencies-on-github-enterprise-server.md @@ -46,7 +46,9 @@ Before enabling {% if currentVersion ver_gt "enterprise-server@2.21" %}{% data v $ ghe-dep-graph-enable ``` {% note %} + **Note**: For more information about enabling access to the administrative shell via SSH, see "[Accessing the administrative shell (SSH)](/enterprise/{{ currentVersion }}/admin/configuration/accessing-the-administrative-shell-ssh)." + {% endnote %} 3. Return to {% data variables.product.prodname_ghe_server %}. From b01e61ea966cb033155014cfbd5c6d39f30393d0 Mon Sep 17 00:00:00 2001 From: djdefi Date: Wed, 21 Oct 2020 09:59:41 -0700 Subject: [PATCH 6/8] Update enabling-alerts-for-vulnerable-dependencies-on-github-enterprise-server.md --- ...ts-for-vulnerable-dependencies-on-github-enterprise-server.md | 1 + 1 file changed, 1 insertion(+) diff --git a/content/admin/configuration/enabling-alerts-for-vulnerable-dependencies-on-github-enterprise-server.md b/content/admin/configuration/enabling-alerts-for-vulnerable-dependencies-on-github-enterprise-server.md index 56bcaa5ee068..dd95bbd00603 100644 --- a/content/admin/configuration/enabling-alerts-for-vulnerable-dependencies-on-github-enterprise-server.md +++ b/content/admin/configuration/enabling-alerts-for-vulnerable-dependencies-on-github-enterprise-server.md @@ -45,6 +45,7 @@ Before enabling {% if currentVersion ver_gt "enterprise-server@2.21" %}{% data v ``` shell $ ghe-dep-graph-enable ``` + {% note %} **Note**: For more information about enabling access to the administrative shell via SSH, see "[Accessing the administrative shell (SSH)](/enterprise/{{ currentVersion }}/admin/configuration/accessing-the-administrative-shell-ssh)." From 67259b7128e6aaefe8e9486b4b815e9e253e3502 Mon Sep 17 00:00:00 2001 From: djdefi Date: Wed, 21 Oct 2020 10:16:27 -0700 Subject: [PATCH 7/8] Update enabling-alerts-for-vulnerable-dependencies-on-github-enterprise-server.md --- ...ts-for-vulnerable-dependencies-on-github-enterprise-server.md | 1 - 1 file changed, 1 deletion(-) diff --git a/content/admin/configuration/enabling-alerts-for-vulnerable-dependencies-on-github-enterprise-server.md b/content/admin/configuration/enabling-alerts-for-vulnerable-dependencies-on-github-enterprise-server.md index dd95bbd00603..56bcaa5ee068 100644 --- a/content/admin/configuration/enabling-alerts-for-vulnerable-dependencies-on-github-enterprise-server.md +++ b/content/admin/configuration/enabling-alerts-for-vulnerable-dependencies-on-github-enterprise-server.md @@ -45,7 +45,6 @@ Before enabling {% if currentVersion ver_gt "enterprise-server@2.21" %}{% data v ``` shell $ ghe-dep-graph-enable ``` - {% note %} **Note**: For more information about enabling access to the administrative shell via SSH, see "[Accessing the administrative shell (SSH)](/enterprise/{{ currentVersion }}/admin/configuration/accessing-the-administrative-shell-ssh)." From 594c994db4e9a06ac45701f3af7862c768ca1d88 Mon Sep 17 00:00:00 2001 From: hubwriter <54933897+hubwriter@users.noreply.github.com> Date: Thu, 22 Oct 2020 09:28:54 +0100 Subject: [PATCH 8/8] Indenting note box in markdown. I should have spotted this in my previous review, so I'm going to go ahead and apply this change. --- ...r-vulnerable-dependencies-on-github-enterprise-server.md | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/content/admin/configuration/enabling-alerts-for-vulnerable-dependencies-on-github-enterprise-server.md b/content/admin/configuration/enabling-alerts-for-vulnerable-dependencies-on-github-enterprise-server.md index 56bcaa5ee068..e073e896dd52 100644 --- a/content/admin/configuration/enabling-alerts-for-vulnerable-dependencies-on-github-enterprise-server.md +++ b/content/admin/configuration/enabling-alerts-for-vulnerable-dependencies-on-github-enterprise-server.md @@ -45,11 +45,11 @@ Before enabling {% if currentVersion ver_gt "enterprise-server@2.21" %}{% data v ``` shell $ ghe-dep-graph-enable ``` -{% note %} + {% note %} -**Note**: For more information about enabling access to the administrative shell via SSH, see "[Accessing the administrative shell (SSH)](/enterprise/{{ currentVersion }}/admin/configuration/accessing-the-administrative-shell-ssh)." + **Note**: For more information about enabling access to the administrative shell via SSH, see "[Accessing the administrative shell (SSH)](/enterprise/{{ currentVersion }}/admin/configuration/accessing-the-administrative-shell-ssh)." -{% endnote %} + {% endnote %} 3. Return to {% data variables.product.prodname_ghe_server %}. {% data reusables.enterprise_site_admin_settings.access-settings %}