Fixing incorrect detection of the NewLisp language #2319
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Isn't the classifier sufficient to solve this issue? I.e., does adding new samples solve it? |
|
Yeah, you can try to check No, I only tested on unit tests. |
The files used for training should always be recognized correctly (otherwise there's something really wrong with the classifier). Do you have some other files wrongly detected as NewLisp? |
|
No, unfortunately. I have fixed in my project by adding .gitattributes. Probably I will create another pull request in the case if I will have enough data to test in the future. |
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The proposed sample file that contains tokenized Dutch words has been wrongly recognized as a NewLisp code in my repository.
This patch is a try to fix this ambiguity.