Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

review use of emojis for cross-platform compatability #1446

Closed
setchy opened this issue Aug 7, 2024 · 11 comments · Fixed by #1449
Closed

review use of emojis for cross-platform compatability #1446

setchy opened this issue Aug 7, 2024 · 11 comments · Fixed by #1449
Assignees
Labels
bug Something isn't working platform:windows Related to windows build priority:high Items of high importance. Applicable to all users or use-cases

Comments

@setchy
Copy link
Member

setchy commented Aug 7, 2024

Originally posted by @Araxeus in #1441 (comment)

Same but the network error icon isnt even rendering for me (Windows)

image

This issue is to review all of our emojis to ensure they exist on macOS, Windows and Linux

@setchy setchy added the bug Something isn't working label Aug 7, 2024
@Araxeus
Copy link
Contributor

Araxeus commented Aug 7, 2024

here are all the emojis that arent supported on my windows machine:

image

@setchy
Copy link
Member Author

setchy commented Aug 7, 2024

and on macOS
Screenshot 2024-08-07 at 11 23 03 AM

@setchy
Copy link
Member Author

setchy commented Aug 7, 2024

@Araxeus
Copy link
Contributor

Araxeus commented Aug 7, 2024

i'm on Windows 10 yes

@setchy
Copy link
Member Author

setchy commented Aug 7, 2024

i'm on Windows 10 yes

Thanks! Looks like Windows 10 is using an Unicode/Emoji set from May 2019.

@Araxeus
Copy link
Contributor

Araxeus commented Aug 7, 2024

Windows 11 has just about 30% adoption rate (source1 -- source2)

so we should probably support Windows 10 😅

@setchy
Copy link
Member Author

setchy commented Aug 7, 2024

@Araxeus - would you mind sharing a screenshot of the ALL_READ_EMOJIS for Windows

macOS
Screenshot 2024-08-07 at 12 24 10 PM

@Araxeus
Copy link
Contributor

Araxeus commented Aug 7, 2024

image

@setchy
Copy link
Member Author

setchy commented Aug 7, 2024

A few possible paths forward which I have prototyped locally

In no particular order

  1. Remove emojis that aren't available on Win10
  2. Continue using emojis, but add special handling for win10 emojis (assuming we can get this level of OS details)
  3. Replace with an equivalent Octicons - already used extensively within the codebase
  4. Replace with an equivalent Heroicons - from tailwindcss
  5. Replace with an equivalent FontAwesome Icon
  6. Replace with twemoji, a popular emoji to svg parser

Any initial thoughts @Araxeus, @afonsojramos, @bmulholland

@Araxeus
Copy link
Contributor

Araxeus commented Aug 8, 2024

I'd say replace them with whatever looks best?

@setchy
Copy link
Member Author

setchy commented Aug 8, 2024

I think I'll prototype going down this route - https://github.com/twitter/twemoji, or the maintained fork https://github.com/jdecked/twemoji

@setchy setchy added platform:windows Related to windows build priority:high Items of high importance. Applicable to all users or use-cases labels Aug 12, 2024
@setchy setchy self-assigned this Aug 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working platform:windows Related to windows build priority:high Items of high importance. Applicable to all users or use-cases
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants