Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notification when personal access token has expired/is no longer valid #1711

Closed
techncl opened this issue Jan 8, 2025 · 4 comments
Closed
Labels
enhancement New feature or enhancement to existing functionality help-wanted Extra attention is needed priority:low Items of low importance. Applicable to select few users or use-cases

Comments

@techncl
Copy link

techncl commented Jan 8, 2025

📝 Provide a description of the new feature

If the token used has expired/is no longer valid, it doesn't alert you; you have to check yourself. It would be nice if:

  1. There was some sort of alert to tell you this.
  2. Maybe the "G" could go red also?

➕ Additional Information

No response

@techncl techncl added the enhancement New feature or enhancement to existing functionality label Jan 8, 2025
@setchy setchy added help-wanted Extra attention is needed priority:low Items of low importance. Applicable to select few users or use-cases labels Jan 8, 2025
@setchy
Copy link
Member

setchy commented Jan 9, 2025

For (1) we do have token error handling that should be showing the error screen... Will need to recreate an expired token scenario and retest

@setchy
Copy link
Member

setchy commented Jan 10, 2025

As promised, overnight I performed a recreation to test

  • Gitify v5.17.0 on macOS
  • GitHub Cloud
  • PAT with 24hr expiration and the minimum 3 scopes (read:user, repo, notifications)
  • Result was as expected, BAD CREDENTIALS error page displayed
    2025-01-10T05-50-15 758Z-gitify-screenshot

@setchy setchy closed this as not planned Won't fix, can't repro, duplicate, stale Jan 10, 2025
@techncl
Copy link
Author

techncl commented Jan 10, 2025

Oh, I see. Maybe I didn't see the notification. Thank you for your quick response and for testing this.

@setchy
Copy link
Member

setchy commented Jan 10, 2025

No problems.

I like the suggestion of a red Gitify icon when things go sideways, I'll look into that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or enhancement to existing functionality help-wanted Extra attention is needed priority:low Items of low importance. Applicable to select few users or use-cases
Projects
None yet
Development

No branches or pull requests

2 participants