Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve documentation for hiding default added editor actions #1445

Closed
shaman-apprentice opened this issue Mar 28, 2021 · 4 comments
Closed
Assignees
Labels
feature New feature or request needs-verification Request for verification
Milestone

Comments

@shaman-apprentice
Copy link

shaman-apprentice commented Mar 28, 2021

UI space / icons to show in the editor action toolbar are opinionated (see microsoft/vscode#46403 or #1211). Therefore, as a user, I want to know how to hide them.

Actual behavior: As stated here the feature is currently not really documented.

Possible solution: Add the following content at the bottom of "Revision Navigation #"-section in README.md.

The default added icons to the editor action toolbar can be hidden as described here.

P.S.: It seems I wasn't the only one missing this section - #1433)

@shaman-apprentice
Copy link
Author

shaman-apprentice commented Mar 28, 2021

As a side note: What do you think about adding an issue type "Documentation"? "Bug report", "Feature request" nor "Question" felt really right to me for this issue.

@eamodio eamodio self-assigned this Mar 28, 2021
@eamodio eamodio added this to the Soon™ milestone Mar 28, 2021
@eamodio eamodio added needs-verification Request for verification and removed triage Needs to be looked at labels Mar 28, 2021
@eamodio
Copy link
Member

eamodio commented Mar 28, 2021

@shaman-apprentice I've added a new section about the menu & toolbar customizations to the README -- Let me know what you think.

@shaman-apprentice
Copy link
Author

Cool. I like it way more, than my minimal addition 👍 Thx!

@eamodio eamodio modified the milestones: Soon™, Shipped Apr 9, 2021
@github-actions
Copy link

github-actions bot commented May 9, 2021

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 9, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature New feature or request needs-verification Request for verification
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants