Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gitlens Panel > Branches > Commit view keeps collapsing #169

Closed
awendland opened this issue Oct 13, 2017 · 6 comments
Closed

Gitlens Panel > Branches > Commit view keeps collapsing #169

awendland opened this issue Oct 13, 2017 · 6 comments
Labels
needs-more-info Needs further information, steps, details, etc.

Comments

@awendland
Copy link

I make heavy usage of the branch commit browser in the Gitlens panel to walk through commits for code review. However, I've been running into an issue where the expanded tree state that I had randomly (and frequently) collapses down to just showing the available branches, instead of maintaining the commit I had expanded and the nested files.

  • GitLens Version: 5.6.4
  • VSCode Version: 1.17.1 as well as older versions
  • OS Version: macOS 10.13

Steps to Reproduce:

  1. Open a branch > then a commit > then a file in the Gitlens panel
  2. Wait several seconds
  3. Witness it automatically collapse w/o user interaction

gitlens-collapse-branches

@eamodio eamodio added the needs-more-info Needs further information, steps, details, etc. label Oct 16, 2017
@eamodio
Copy link
Member

eamodio commented Oct 16, 2017

@awendland While the state of the GitLens explorer isn't close to where I would like it, in terms of refreshes losing all context, there are a few blocking vscode issues:

microsoft/vscode#34789
microsoft/vscode#30535
microsoft/vscode#33371

Although at the same time, I can't reproduce the behavior you are seeing -- I can expand something in the view and it will stay that way until something changes -- like a file in the repo, or the repo state itself (which could be updated by vscode's auto-fetch (via the git.autofetch setting).

Have you noticed any rhyme or reason to when it refreshes and loses its context? Can you try setting "git.autofetch": false and see if that changes the behavior? Any more details you can provide would be greatly appreciated.

@awendland
Copy link
Author

@eamodio Thanks for detailing the issues behind this and for looking into it. GitLens has become an integral part of my flow because of how high quality it is, so I must imagine these vscode limitations are frustrating you to no end 😂

Setting git.autofetch hasn't helped the issue at all unfortunately. For the time being the hammer approach that you've mentioned in #180 is what I'll be using, and I'll make sure to up-vote the appropriate vscode issues wherever possible. Thanks again for such a great extension!

@eamodio
Copy link
Member

eamodio commented Oct 28, 2017

No problem and thank you for your kind words!

Hrm, while there are a lot of known issues with refreshes collapsing everything, I'm still unsure why you are experiencing it if nothing changed. Would you mind trying out the latest GitLens v6 alpha? I've refactored a lot to reduce extra events and overhead which might have an effect here. It also has more improved logging that might help determine why the view is refreshing.

@eamodio
Copy link
Member

eamodio commented Nov 9, 2017

@awendland GitLens 6 is out now, if you are still experiencing this issue, please re-open this and attach logs -- thanks!

@eamodio eamodio closed this as completed Nov 9, 2017
@awendland
Copy link
Author

@eamodio The problem seems to have been fixed! Thank you! An era of code review bliss has arrived 😄

@github-actions
Copy link

github-actions bot commented Dec 7, 2020

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 7, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
needs-more-info Needs further information, steps, details, etc.
Projects
None yet
Development

No branches or pull requests

2 participants