Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable option for rebase interactive editor is not honoured #2051

Closed
Jule- opened this issue Jun 23, 2022 · 3 comments
Closed

Enable option for rebase interactive editor is not honoured #2051

Jule- opened this issue Jun 23, 2022 · 3 comments
Labels
bug Something isn't working

Comments

@Jule-
Copy link

Jule- commented Jun 23, 2022

Issue Type: Bug

  1. Start vscode on a git project folder
  2. Run in command palette: GitLens: Enable Interactive Rebase Editor (or add in your settings.json "workbench.editorAssociations": { "git-rebase-todo": "gitlens.rebase" })
  3. Create dummy temporary local commit
  4. Open integrated terminal
  5. Run git rebase --interactive

=> The default text editor is opened instead of the GitLens editor.

NB: If I run the git rebase --interactive command from an external terminal it correctly shows the GitLens editor.


Extension version: 12.1.1
Git Version: 2.25.1
VS Code version: Code - Insiders 1.69.0-insider (10e6e876822fa2da15fb68e8a6f1fb9aa8d94ce2, 2022-06-21T05:17:51.280Z)
OS version: Linux x64 5.4.0-120-generic
Restricted Mode: No

@Jule-
Copy link
Author

Jule- commented Jun 23, 2022

I've found this issue #1687 that sounds like the opposite bug so maybe its fix could be the cause of this bug.

@d13 d13 added potential-bug triage Needs to be looked at labels Jun 27, 2022
@Jule-
Copy link
Author

Jule- commented Jun 29, 2022

I am not sure about what has changed but it seems that the situation come back to normal since I have this VSCode Insiders version: Code - Insiders 1.69.0-insider (e7751367f79f327b8103bee33a07c16817a2c7cd, 2022-06-28T05:18:13.217Z).

I close this issue for now and maybe will reopen it if it happens to me again.

@Jule- Jule- closed this as completed Jun 29, 2022
@github-actions
Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 30, 2022
@eamodio eamodio added bug Something isn't working and removed potential-bug labels Apr 12, 2023
@eamodio eamodio removed the triage Needs to be looked at label Dec 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants