Add GitLab Data Group

[matejvelikonja]

This PR adds a new data resource gitlab_group.
You can access GitLab group via group_id or full_path.

Fixes #103

data "gitlab_group" "foo1" {
  full_path = "foo/bar"
}

data "gitlab_group" "foo2" {
  group_id = 123
}

[mkjmdski]

+1

[jorcau]

Thanks @matejvelikonja.

I think you forgot to edit doc arborescence website/gitlab.erb with the new datasource.

Also, maybe it'd be better to separate group resource changes into another PR to make this one clearer?

[matejvelikonja]

not really sure, why would TestAccGitlabProject_basic fail with this changes.

--- FAIL: TestAccGitlabProject_basic (6.06s)
    testing.go:568: Step 1 error: Check failed: Check 2/2 error: 1 error occurred:
        	* Check 5/22 error: attribute tags expected "&{F:0xf04970 m:map[4151227546:tag1 1852302624:tag2] once:{m:{state:0 sema:0} done:1}}" received "&{F:0xf04970 m:map[4151227546:tag1 1852302624:tag2] once:{m:{state:0 sema:0} done:1}}"

and acceptances tests work on my machine. Probably a temporary glitch.

=== RUN   TestAccDataSourceGitlabGroup_basic
--- PASS: TestAccDataSourceGitlabGroup_basic (14.38s)
=== RUN   TestAccDataGitlabProject_basic
--- PASS: TestAccDataGitlabProject_basic (7.86s)
=== RUN   TestAccDataSourceGitlabUser_basic
--- PASS: TestAccDataSourceGitlabUser_basic (1.61s)
=== RUN   TestAccDataSourceGitlabUsers_basic
--- PASS: TestAccDataSourceGitlabUsers_basic (1.62s)
=== RUN   TestProvider
--- PASS: TestProvider (0.00s)
=== RUN   TestProvider_impl
--- PASS: TestProvider_impl (0.00s)
=== RUN   TestAccGitlabBranchProtection_basic
--- PASS: TestAccGitlabBranchProtection_basic (8.01s)
=== RUN   TestAccGitlabDeployKey_basic
--- PASS: TestAccGitlabDeployKey_basic (8.29s)
=== RUN   TestAccGitlabDeployKey_suppressfunc
--- PASS: TestAccGitlabDeployKey_suppressfunc (6.04s)
=== RUN   TestAccGitlabDeployKey_import
--- PASS: TestAccGitlabDeployKey_import (6.12s)
=== RUN   TestAccGitlabGroupMembership_basic
--- PASS: TestAccGitlabGroupMembership_basic (7.42s)
=== RUN   TestAccGitlabGroup_basic
--- PASS: TestAccGitlabGroup_basic (6.35s)
=== RUN   TestAccGitlabGroup_import
--- PASS: TestAccGitlabGroup_import (5.66s)
=== RUN   TestAccGitlabGroup_nested
--- PASS: TestAccGitlabGroup_nested (27.85s)
=== RUN   TestAccGitlabGroupVariable_basic
--- PASS: TestAccGitlabGroupVariable_basic (6.49s)
=== RUN   TestAccGitlabLabel_basic
--- PASS: TestAccGitlabLabel_basic (8.02s)
=== RUN   TestAccGitlabPipelineTrigger_basic
--- PASS: TestAccGitlabPipelineTrigger_basic (7.46s)
=== RUN   TestAccGitlabProjectCluster_basic
--- PASS: TestAccGitlabProjectCluster_basic (8.17s)
=== RUN   TestAccGitlabProjectCluster_import
--- PASS: TestAccGitlabProjectCluster_import (6.26s)
=== RUN   TestAccGitlabProjectHook_basic
--- PASS: TestAccGitlabProjectHook_basic (7.36s)
=== RUN   TestAccGitlabProjectMembership_basic
--- PASS: TestAccGitlabProjectMembership_basic (7.55s)
=== RUN   TestAccGitlabProject_basic
--- PASS: TestAccGitlabProject_basic (15.43s)
=== RUN   TestAccGitlabProject_import
--- PASS: TestAccGitlabProject_import (6.07s)
=== RUN   TestAccGitlabProject_nestedImport
--- PASS: TestAccGitlabProject_nestedImport (11.45s)
=== RUN   TestAccGitlabProjectVariable_basic
--- PASS: TestAccGitlabProjectVariable_basic (7.01s)
=== RUN   TestAccGitlabServiceSlack_basic
--- PASS: TestAccGitlabServiceSlack_basic (8.46s)
=== RUN   TestAccGitlabServiceSlack_import
--- PASS: TestAccGitlabServiceSlack_import (6.06s)
=== RUN   TestAccGitlabUser_basic
--- PASS: TestAccGitlabUser_basic (1.18s)
=== RUN   TestGitlab_validation
--- PASS: TestGitlab_validation (0.00s)
=== RUN   TestGitlab_visbilityHelpers
--- PASS: TestGitlab_visbilityHelpers (0.00s)
PASS
ok  	github.com/terraform-providers/terraform-provider-gitlab/gitlab	208.217s

[matejvelikonja]

@roidelapluie anything else to do here?

[Johnee]

Thanks @matejvelikonja, this feature will be very useful to us, once it gets merged. Hopefully soon..

[roidelapluie]

This will be released in the coming days. I will merge it soon after 2.0.0 is released.

[matejvelikonja]

@roidelapluie any news when version 2.1 will be relased?