Resolve triggers pagination issue by calling GetPipelineTrigger #173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
roidelapluie
requested changes
Sep 11, 2019
| found = true | ||
| break | ||
| if response.StatusCode == 404 { | ||
| log.Printf("[WARN] removing PipelineTrigger %d from state because it no longer exists in gitlab", pipelineTriggerID) |
There was a problem hiding this comment.
We do not do this anymore in the prodiver
There was a problem hiding this comment.
I just followed the existing logic .
if !found {
log.Printf("[WARN] removing PipelineTrigger %d from state because it no longer exists in gitlab", pipelineTriggerID)
d.Set("description", pipelineTrigger.Description)
d.SetId("") d.Set("token", pipelineTrigger.Token)
}
So this should be removed as part of this PR ?
There was a problem hiding this comment.
I've removed the code in question.
jhuntoo
force-pushed
the
fix-pipeline-triggers-pagination-issue
branch
from
86821f9 to
32570e6
Compare
|
Thanks! |
|
@roidelapluie can you give any indication on when you might make a release including this fix? :) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #172 .