Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move to V4 API #20

Merged
merged 1 commit into from
Sep 27, 2017
Merged

Move to V4 API #20

merged 1 commit into from
Sep 27, 2017

Conversation

roidelapluie
Copy link
Collaborator

@roidelapluie roidelapluie commented Sep 22, 2017 •
edited
Loading

Fixes #3

@roidelapluie
Copy link
Collaborator Author 

==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test $(go list ./... |grep -v 'vendor') -v  -timeout 120m
?       github.com/terraform-providers/terraform-provider-gitlab        [no test files]
=== RUN   TestProvider
--- PASS: TestProvider (0.00s)
=== RUN   TestProvider_impl
--- PASS: TestProvider_impl (0.00s)
=== RUN   TestAccGitlabDeployKey_basic
--- PASS: TestAccGitlabDeployKey_basic (2.19s)
=== RUN   TestAccGitlabGroup_basic
--- PASS: TestAccGitlabGroup_basic (0.72s)
=== RUN   TestAccGitlabProjectHook_basic
--- PASS: TestAccGitlabProjectHook_basic (2.03s)
=== RUN   TestAccGitlabProject_basic
--- PASS: TestAccGitlabProject_basic (2.06s)
=== RUN   TestGitlab_validation
--- PASS: TestGitlab_validation (0.00s)
=== RUN   TestGitlab_visbilityHelpers
--- PASS: TestGitlab_visbilityHelpers (0.00s)
PASS
ok      github.com/terraform-providers/terraform-provider-gitlab/gitlab 7.022s

@tombuildsstuff
Copy link
Contributor

tombuildsstuff commented Sep 25, 2017 •
edited
Loading

I think this needs to be merged after #19 and #7?

tombuildsstuff
tombuildsstuff approved these changes Sep 25, 2017
View reviewed changes
Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @roidelapluie

Thanks for this PR :)

From what I can see this needs to be merged after #19 and #7 (where there was a question about if this is still needed?) - but this otherwise LGTM :)

Thanks!

@roidelapluie
Copy link
Collaborator Author

#19 is included in this PR

#7 is not needed coz it has been fixed upstream in gitlab

thanks

@roidelapluie
Copy link
Collaborator Author

@tombuildsstuff rebased

$ make testacc 
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test $(go list ./... |grep -v 'vendor') -v  -timeout 120m
?       github.com/terraform-providers/terraform-provider-gitlab        [no test files]
=== RUN   TestProvider
--- PASS: TestProvider (0.00s)
=== RUN   TestProvider_impl
--- PASS: TestProvider_impl (0.00s)
=== RUN   TestAccGitlabDeployKey_basic
--- PASS: TestAccGitlabDeployKey_basic (6.69s)
=== RUN   TestAccGitlabGroup_basic
--- PASS: TestAccGitlabGroup_basic (0.79s)
=== RUN   TestAccGitlabProjectHook_basic
--- PASS: TestAccGitlabProjectHook_basic (5.95s)
=== RUN   TestAccGitlabProject_basic
--- PASS: TestAccGitlabProject_basic (5.91s)
=== RUN   TestGitlab_validation
--- PASS: TestGitlab_validation (0.00s)
=== RUN   TestGitlab_visbilityHelpers
--- PASS: TestGitlab_visbilityHelpers (0.00s)
PASS
ok      github.com/terraform-providers/terraform-provider-gitlab/gitlab 19.333s

richardc
richardc reviewed Sep 26, 2017
View reviewed changes
gitlab/resource_gitlab_project.go Outdated
return err
}

// Wait for the datacenter resource to be ready
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Datacenter? Is this bad copy and paste?

richardc
richardc reviewed Sep 26, 2017
View reviewed changes
gitlab/resource_gitlab_project_hook.go
@@ -89,7 +84,6 @@ func resourceGitlabProjectHookCreate(d *schema.ResourceData, meta interface{}) e
MergeRequestsEvents: gitlab.Bool(d.Get("merge_requests_events").(bool)),
TagPushEvents: gitlab.Bool(d.Get("tag_push_events").(bool)),
NoteEvents: gitlab.Bool(d.Get("note_events").(bool)),
BuildEvents: gitlab.Bool(d.Get("build_events").(bool)),
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These got renamed to JobEvents which go-gitlab does support; https://github.com/xanzy/go-gitlab/blob/master/projects.go#L590

@roidelapluie
Upgrade to API v4
1b63c6e 
Closes #3

Signed-off-by: Julien Pivotto <[email protected]>
attachmentgenie
attachmentgenie approved these changes Sep 27, 2017
View reviewed changes
Copy link
Collaborator

@attachmentgenie attachmentgenie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looking good to me, LGTM

@roidelapluie
Copy link
Collaborator Author 

==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test $(go list ./... |grep -v 'vendor') -v  -timeout 120m
?       github.com/terraform-providers/terraform-provider-gitlab        [no test files]
=== RUN   TestProvider
--- PASS: TestProvider (0.00s)
=== RUN   TestProvider_impl
--- PASS: TestProvider_impl (0.00s)
=== RUN   TestAccGitlabDeployKey_basic
--- PASS: TestAccGitlabDeployKey_basic (6.05s)
=== RUN   TestAccGitlabGroup_basic
--- PASS: TestAccGitlabGroup_basic (0.59s)
=== RUN   TestAccGitlabProjectHook_basic
--- PASS: TestAccGitlabProjectHook_basic (5.83s)
=== RUN   TestAccGitlabProject_basic
--- PASS: TestAccGitlabProject_basic (5.94s)
=== RUN   TestGitlab_validation
--- PASS: TestGitlab_validation (0.00s)
=== RUN   TestGitlab_visbilityHelpers
--- PASS: TestGitlab_visbilityHelpers (0.00s)
PASS
ok      github.com/terraform-providers/terraform-provider-gitlab/gitlab 18.412s

@roidelapluie roidelapluie merged commit 75b042b into gitlabhq:master Sep 27, 2017
roidelapluie added a commit that referenced this pull request Sep 27, 2017
@roidelapluie
Add changelog for #20
4742657
@roidelapluie roidelapluie added this to the 0.2.0 milestone Oct 1, 2017
cehoffman pushed a commit to VertivSRE/terraform-provider-gitlab that referenced this pull request Jan 23, 2018
@roidelapluie
Merge pull request gitlabhq#20 from roidelapluie/v4
0bd37f4 
Move to V4 API
cehoffman pushed a commit to VertivSRE/terraform-provider-gitlab that referenced this pull request Jan 23, 2018
@roidelapluie
Add changelog for gitlabhq#20
f72e92c
@github-actions github-actions bot locked and limited conversation to collaborators Nov 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@richardc richardc richardc left review comments

@tombuildsstuff tombuildsstuff tombuildsstuff approved these changes

@attachmentgenie attachmentgenie attachmentgenie approved these changes

Assignees
No one assigned
Labels
enhancement
Milestone
0.2.0
Development

Successfully merging this pull request may close these issues.
4 participants
@roidelapluie @tombuildsstuff @richardc @attachmentgenie