Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Github Actions Workflows #216

Merged
merged 6 commits into from
Mar 23, 2020
Merged

Use Github Actions Workflows #216

merged 6 commits into from
Mar 23, 2020

Conversation

roidelapluie
Copy link
Collaborator

Signed-off-by: Julien Pivotto [email protected]

@ghost ghost added the size/XS label Nov 17, 2019
@roidelapluie roidelapluie force-pushed the workflow branch 3 times, most recently from c56e9fc to c94ba07 Compare November 17, 2019 19:21
@ghost ghost added size/S and removed size/XS labels Nov 17, 2019
@roidelapluie roidelapluie force-pushed the workflow branch 2 times, most recently from 11b18f7 to 363252b Compare November 17, 2019 19:23
@ghost ghost added size/XS and removed size/S labels Nov 17, 2019
@roidelapluie @ringods
Use GH Worksflow
80dcbef 
Signed-off-by: Julien Pivotto <[email protected]>
@ringods ringods self-assigned this Mar 22, 2020
@ringods ringods changed the title Use GH Worksflow Use Github Actions Workflows Mar 23, 2020
@ringods ringods merged commit dda78c0 into master Mar 23, 2020
@ringods ringods deleted the workflow branch March 23, 2020 20:53
@roidelapluie
Copy link
Collaborator Author

Should we remove travis?

@ringods
Copy link
Contributor

ringods commented Mar 24, 2020

@roidelapluie not yet. The acceptance tests, even for CE, are not correctly set up yet in Github Actions. Can you explain me what this line exactly does?

https://github.com/terraform-providers/terraform-provider-gitlab/blob/dda78c0a5043b7fb135d68c3119ceea99b6f0c3b/scripts/start-gitlab.sh#L39

It is the only line I see related to GITLAB_TOKEN but it doesn't work in Github Actions it seems.

@ringods
Copy link
Contributor

ringods commented Apr 1, 2020

@roidelapluie Travis may be removed now that #285 is merged.

ahmet2mir pushed a commit to ahmet2mir/terraform-provider-gitlab that referenced this pull request Sep 15, 2020
@ringods
Merge pull request gitlabhq#216 from terraform-providers/workflow
32fdc7a 
Use Github Actions Workflows
@github-actions github-actions bot locked and limited conversation to collaborators Nov 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@ringods ringods

Labels
size/M
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@roidelapluie @ringods