Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to change user email without recreating the resource #261

Merged
merged 5 commits into from
Sep 8, 2020

Conversation

ilpianista
Copy link
Contributor

I imported an user into the terraform state and after I set the mandatory arguments the provider wanted to delete and recreate such user even if I didn't change anything.

This PRs maps the missing user attributes into the state.

@ghost ghost added the size/XS label Feb 21, 2020
@ilpianista ilpianista force-pushed the bugfix/user-attributes-state branch from 85b92dd to 7a6192f Compare February 22, 2020 02:00
@ghost ghost added size/S and removed size/XS labels Feb 22, 2020
@ilpianista ilpianista force-pushed the bugfix/user-attributes-state branch 4 times, most recently from a586495 to da84341 Compare February 24, 2020 11:39
@ilpianista
Copy link
Contributor Author

@roidelapluie this was bigger than I expected (there were a lot of problems under the hood).
Please take a look to each commit to understand the purpose of each change.

I opened a bug to GitLab about the 'external' flag causing issues after update.

@ilpianista ilpianista force-pushed the bugfix/user-attributes-state branch from da84341 to 4c49ddf Compare February 24, 2020 12:00
@ilpianista ilpianista changed the title Import more user attributes into the state Allow to change user email without recreating the resource Feb 25, 2020
@ilpianista ilpianista force-pushed the bugfix/user-attributes-state branch from 4c49ddf to 68f7674 Compare April 7, 2020 12:34
@ilpianista ilpianista force-pushed the bugfix/user-attributes-state branch from 68f7674 to 3ab5042 Compare September 8, 2020 09:28
Copy link
Collaborator

@armsnyder armsnyder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this, and fixing the test! If you have any ideas for how to make tests less prone to mistakes in the future, I'd be interested.

@armsnyder armsnyder merged commit f201ea2 into gitlabhq:master Sep 8, 2020
@ilpianista ilpianista deleted the bugfix/user-attributes-state branch September 9, 2020 07:11
@github-actions github-actions bot locked and limited conversation to collaborators Nov 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Development

Successfully merging this pull request may close these issues.

2 participants