Make password and reset_password exclusive #262
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
ilpianista
force-pushed
the
feature/optional-password
branch
from
fb3a12c to
66cf697
Compare
|
Can we have an acceptance test with an empty password? |
ilpianista
force-pushed
the
feature/optional-password
branch
from
66cf697 to
58067bf
Compare
|
@roidelapluie is this OK as test? I don't set a password during the creation, but then it's set during the user update test. Still, I don't think we can check if the password has been set because the password is (obviously) never sent back by GitLab. Thus, I removed that part. |
ilpianista
force-pushed
the
feature/optional-password
branch
from
e254509 to
3954d82
Compare
ilpianista
force-pushed
the
feature/optional-password
branch
from
3954d82 to
94087df
Compare
ilpianista
force-pushed
the
feature/optional-password
branch
from
94087df to
9432fb7
Compare
ilpianista
changed the title
|
Making the password optional has been solved by #340, so this PR now just ensure that either |
ilpianista
force-pushed
the
feature/optional-password
branch
from
9432fb7 to
1033886
Compare
ilpianista
force-pushed
the
feature/optional-password
branch
from
1033886 to
ffca640
Compare
|
@ilpianista Can you add two new tests?
|
|
@armsnyder I implemented 2). To implement 1), I simply removed the |
ilpianista
force-pushed
the
feature/optional-password
branch
from
b779e7d to
46a9dbf
Compare
armsnyder
reviewed
Sep 9, 2020
Co-authored-by: Adam Snyder <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The documentation works when either
passwordorreset_passwordis set.