Add masked attribute to group variables

[kirecek]

Related issue https://github.com/terraform-providers/terraform-provider-gitlab/issues/243

[kirecek]

Don't understand why the test is failing. I cannot replicate it locally (using gitlab:latest):

$ TESTARGS="-run TestAccGitlabGroup_disappears" make testacc
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test $(go list ./... |grep -v 'vendor') -v -run TestAccGitlabGroup_disappears -timeout 120m
?   	github.com/terraform-providers/terraform-provider-gitlab	[no test files]
=== RUN   TestAccGitlabGroup_disappears
--- PASS: TestAccGitlabGroup_disappears (0.42s)
PASS
ok  	github.com/terraform-providers/terraform-provider-gitlab/gitlab	0.431s

Also looking at code and it does not make any sense to me why the state would be empty

[emmanuelCarre]

Hi,
I am not familiar with travis ci, let me know what you think about my hypothesis:
Gitlab version is not fixed: https://github.com/terraform-providers/terraform-provider-gitlab/blob/master/scripts/start-gitlab.sh#L14; and I didn't see where we define pull strategy. I think CI use an too old image because argument is added into API into master code but it will be release in few days: https://gitlab.com/gitlab-org/gitlab/-/merge_requests/25283.

A simple way to fix it is: add docker pull $img at line 16 of start-gitlab.sh but it will increase start time to everyone. A second way could be add argument to this script to force pull image when needed (in travis for example).

EDIT:
I refer this error

--- FAIL: TestAccGitlabProject_basic (13.65s)
    testing.go:635: Step 5 error: errors during apply:
        Error: PUT http://127.0.0.1:8080/api/v4/projects/17: 500 {message: 500 Internal Server Error}
          on /tmp/tf-test150247574/main.tf line 2:
          (source code not available)

EDIT2: Error above is not same api as https://gitlab.com/gitlab-org/gitlab/-/merge_requests/25283 :S

[emmanuelCarre]

Hi,

There is something else to do to merge this merge request? May I help?
To be honnest, I am really interested about this feature :)

Thank you for this development.

[kirecek]

There is something else to do to merge this merge request? May I help?

The issue I mentioned above was fixed after I rebased master. Only thing we can do now is to wait for a review.

Rebased again now to pull master changes.

[sirlatrom]

@ringods Any chance you could give this a quick look?