Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deploy token #284

Merged
merged 1 commit into from
May 31, 2020
Merged

Deploy token #284

merged 1 commit into from
May 31, 2020

Conversation

borgoat
Copy link
Contributor

@borgoat borgoat commented Mar 24, 2020

Fixes #107 plus group tokens.

Tests pass but marked as WIP because of a couple of bugs from GitLab:

which create issues with the username and expires_at field respectively.

As soon as those are solved I'll remove a couple of TODOs and this should be fully working then.

@dylanmtaylor
Copy link

dylanmtaylor commented Apr 20, 2020

Awesome work! Both of the bugs for GitLab look to be resolved with fixes merged, do you have any additional blockers on this feature?

@borgoat
Copy link
Contributor Author

borgoat commented Apr 20, 2020

Hey @dylanmtaylor

I just got the notification from GitLab saying it's fixed, I'll try out the new tests and it should be good to go

@borgoat
Copy link
Contributor Author

borgoat commented Apr 20, 2020

It breaks here, but it looks good on GitLab.com.
We need to wait for 12.10 before this fix is available in the Docker image and thus for this acceptance test to pass. At least according to the milestone in the GitLab issue

@borgoat borgoat changed the title [WIP] Deploy token Deploy token Apr 20, 2020
@adrienbrault
Copy link

@giorgioazzinnaro Has the gitlab release addressed the remaining hurdle?

@vymarkov
Copy link

vymarkov commented May 3, 2020

@giorgioazzinnaro seems to me, make sense to rerun tests

@borgoat
Copy link
Contributor Author

borgoat commented May 3, 2020

Hey sorry folks, I had missed the GitLab release!
I just submitted a fresh build, which is now working on CE, but somehow broken on EE? 🤔
I doubt it has anything to do with this specific branch though, as I see it's failing for other PRs too and complaining about a missing licence.

@ringods
Copy link
Contributor

ringods commented May 30, 2020

@giorgioazzinnaro can you git rebase your work with the latest from master?

After rebasing, the EE tests will be skipped because running the with a license in a PR is not supported for security reasons.

@borgoat
Copy link
Contributor Author

borgoat commented May 30, 2020

Hey @ringods ! Rebased and squashed, I think it should be good to go!

@ringods ringods merged commit 2b4bee5 into gitlabhq:master May 31, 2020
@ringods
Copy link
Contributor

ringods commented Jun 2, 2020

Released in v2.9.0

ahmet2mir pushed a commit to ahmet2mir/terraform-provider-gitlab that referenced this pull request Sep 15, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Nov 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Development

Successfully merging this pull request may close these issues.

[Feature Request] Project deploy tokens
5 participants