-
Notifications
You must be signed in to change notification settings - Fork 319
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deploy token #284
Deploy token #284
Conversation
Awesome work! Both of the bugs for GitLab look to be resolved with fixes merged, do you have any additional blockers on this feature? |
Hey @dylanmtaylor I just got the notification from GitLab saying it's fixed, I'll try out the new tests and it should be good to go |
It breaks here, but it looks good on GitLab.com. |
@giorgioazzinnaro Has the gitlab release addressed the remaining hurdle? |
@giorgioazzinnaro seems to me, make sense to rerun tests |
Hey sorry folks, I had missed the GitLab release! |
@giorgioazzinnaro can you After rebasing, the EE tests will be skipped because running the with a license in a PR is not supported for security reasons. |
Hey @ringods ! Rebased and squashed, I think it should be good to go! |
Released in v2.9.0 |
Fixes #107 plus group tokens.
Tests pass but marked as WIP because of a couple of bugs from GitLab:
which create issues with the
username
andexpires_at
field respectively.As soon as those are solved I'll remove a couple of TODOs and this should be fully working then.